Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 11 support: Currency formats #966

Closed
iluwatar opened this issue Oct 6, 2019 · 9 comments
Closed

Java 11 support: Currency formats #966

iluwatar opened this issue Oct 6, 2019 · 9 comments

Comments

@iluwatar
Copy link
Owner

iluwatar commented Oct 6, 2019

This task is part of the Java 11 transition plan https://github.com/iluwatar/java-design-patterns/wiki/16.-Java-11-Transition

Do we use currency formats that could cause problems, as described in https://winterbe.com/posts/2018/08/29/migrate-maven-projects-to-java-11-jigsaw/? Report findings under this issue.

@mgabor6
Copy link

mgabor6 commented Oct 7, 2019

Hey, can I take this as my first issue? :)
Would check the sources if they use the related Java methods.

@iluwatar
Copy link
Owner Author

iluwatar commented Oct 7, 2019

Hello @mgabor6 👋 I think it's a good first issue. Please go ahead with the check.

@mgabor6
Copy link

mgabor6 commented Oct 8, 2019

Thanks! I've checked the code base specifically for currency formatting, and there are no usage of it. Although there is possible, that the same could occur at general number or date formatting, because they both depends on Locale, so I've started to dive into Java 11 formatting, and will write some tests for these.

@iluwatar
Copy link
Owner Author

iluwatar commented Oct 8, 2019

Ok @mgabor6 let us know how it goes 👍

@iluwatar
Copy link
Owner Author

@mgabor6 any news?

@iluwatar
Copy link
Owner Author

The result of the investigation was that Java currencies are not used in the project.

@mgabor6
Copy link

mgabor6 commented Nov 3, 2019

Hey @iluwatar . Sorry for the hiatus, I had ongoing projects, and they just ended. From now on I'll have some spare time to dive into Java 11 formatting if needed.

@iluwatar
Copy link
Owner Author

iluwatar commented Nov 3, 2019

@mgabor6 no problem. I think there's nothing to investigate in this issue anymore, but please look into other tasks if you find something interesting.

https://github.com/iluwatar/java-design-patterns/issues

@mgabor6
Copy link

mgabor6 commented Nov 5, 2019

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants