Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 11 support: Build with JDK11 #976

Closed
iluwatar opened this issue Oct 10, 2019 · 5 comments
Closed

Java 11 support: Build with JDK11 #976

iluwatar opened this issue Oct 10, 2019 · 5 comments

Comments

@iluwatar
Copy link
Owner

This task is part of the Java 11 transition plan https://github.com/iluwatar/java-design-patterns/wiki/16.-Java-11-Transition

Configure Maven plugins to use Java 11 and verify that build works using JDK11 (see https://winterbe.com/posts/2018/08/29/migrate-maven-projects-to-java-11-jigsaw/ and https://www.baeldung.com/maven-java-version)

@iluwatar
Copy link
Owner Author

@lbroman @perwramdemark working on this?

@lbroman
Copy link
Contributor

lbroman commented Oct 11, 2019

PR #975 should take care of this. Building through the project now, will push the PR in a few minutes.

@iluwatar
Copy link
Owner Author

Sorry, wrong issue I was editing. Reopened.

@lbroman
Copy link
Contributor

lbroman commented Oct 11, 2019

In my PR #980 I have left language source and target at 8 for the naked-objects/dom module. This is because java 11 bytecode breaks the datanucleus enhancer, even if they claim that 5.2 should support java 11 bytecode.
I have tried fiddling with the datanucleus dependency versions because the module uses datanucleus core 5 and apis from 4 so I thought that might be the problem. However, bumping up the versions breaks other stuff as they seem to have moved around some classes between 4 and 5.

@iluwatar
Copy link
Owner Author

I created follow-up task #983 about the datanucleus issue you described @lbroman. As such I think this issue can be closed. Many thanks for the hard work you've done so far 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants