-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get by Country Code with ignore case #19
Comments
Hi, Michael! Nice thought. |
Hi @ilyabreev are you still open to a PR to improve matching? In trying to parse some data of poor quality we have identified the following improvements:
If you're happy to consider such a PR do you have any contribution guidelines? |
@lehtoj Are you still interested in maintaining this repo? |
My deepest apologies, but I am not. |
@ma499 You're welcome to create a PR. This repo don't have any contribution guidelines. I'll try to review your PR by myself. |
Hi,
I just noticed that
GetCountryByAlpha2
(and I assume GetCountryByAlpha3 as well) is case-sensitive. How about adding a parameter that allows this check to ignore case (or even make this the default)?When comparing country codes I never rely on casing.
Cheers
Michael
The text was updated successfully, but these errors were encountered: