Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get by Country Code with ignore case #19

Open
zaha opened this issue Feb 1, 2019 · 5 comments
Open

Get by Country Code with ignore case #19

zaha opened this issue Feb 1, 2019 · 5 comments

Comments

@zaha
Copy link
Contributor

zaha commented Feb 1, 2019

Hi,

I just noticed that GetCountryByAlpha2 (and I assume GetCountryByAlpha3 as well) is case-sensitive. How about adding a parameter that allows this check to ignore case (or even make this the default)?

When comparing country codes I never rely on casing.

Cheers
Michael

@ilyabreev
Copy link
Owner

Hi, Michael!

Nice thought.
Please, feel free to open a PR.

@ma499
Copy link

ma499 commented Apr 14, 2022

Hi @ilyabreev are you still open to a PR to improve matching? In trying to parse some data of poor quality we have identified the following improvements:

  • Case insensitive matching
  • Trim whitespace
  • Trim "The" prefix or " (the)", ", the" suffixes
  • Fuzzy match for typos (this one would be only by parameter or by having duplicate methods e.g. GetCountryByFuzyShortName)

If you're happy to consider such a PR do you have any contribution guidelines?

@ilyabreev
Copy link
Owner

@lehtoj Are you still interested in maintaining this repo?

@lehtoj
Copy link
Contributor

lehtoj commented Apr 30, 2022

@lehtoj Are you still interested in maintaining this repo?

My deepest apologies, but I am not.

@ilyabreev
Copy link
Owner

@ma499 You're welcome to create a PR. This repo don't have any contribution guidelines. I'll try to review your PR by myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants