Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

304 response even on forced cache refresh #21

Open
mfernea opened this issue Aug 26, 2010 · 1 comment
Open

304 response even on forced cache refresh #21

mfernea opened this issue Aug 26, 2010 · 1 comment
Labels

Comments

@mfernea
Copy link

mfernea commented Aug 26, 2010

When forcing a cache refresh (ctrl+f5) scaffold still returns a 304 not modified response.
It seems to me that the problem appers because modified method in Scaffold_Response_Cache class doesn't check if the _modified_since has a proper value. Thus the comparison returns false even if _modified_since is set to 0.

Other problem is that _modified_since is an integer and $last_modified is a string.

Anyway, I'm very glad to see that the work on this project is continuing.
Best regards!

@anthonyshort
Copy link
Collaborator

Thanks, I'll take a look at this and get back to you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants