Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ARM (M1 mac) #59

Closed
murugaratham opened this issue Oct 27, 2021 · 4 comments
Closed

Support ARM (M1 mac) #59

murugaratham opened this issue Oct 27, 2021 · 4 comments
Labels
completed Completed - pending requester to test

Comments

@murugaratham
Copy link

Error response from daemon: image with reference im2nguyen/rover was found but does not match the specified platform: wanted linux/arm64, actual: linux/amd64

@im2nguyen
Copy link
Owner

Hrm, interesting. I built rover using go 1.17 which should have ARM (M1 mac) support.

Based on the error message you provided, it seems like you installed the wrong binary version (linux/ambd64) instead of the actual one needed for your system (linux/arm64).

Here's the zip file for rover v0.2.2 linux/arm64

@im2nguyen im2nguyen added the completed Completed - pending requester to test label Nov 4, 2021
@murugaratham
Copy link
Author

murugaratham commented Nov 5, 2021

I'm actually using docker, and it's most likely a problem with the docker images aren't built to be multi arch.

I have other applications written in .net that are built for arm64, but the base images themselves were built for amd64. Have you tried buildx?

edit: i've looked up on github actions, i think it's just a simple property:

https://github.com/docker/build-push-action/blob/master/docs/advanced/multi-platform.md

name: ci

on:
  push:
    branches:
      - 'master'

jobs:
  docker:
    runs-on: ubuntu-latest
    steps:
      -
        name: Checkout
        uses: actions/checkout@v2
      -
        name: Set up QEMU
        uses: docker/setup-qemu-action@v1
      -
        name: Set up Docker Buildx
        uses: docker/setup-buildx-action@v1
      -
        name: Login to DockerHub
        uses: docker/login-action@v1 
        with:
          username: ${{ secrets.DOCKERHUB_USERNAME }}
          password: ${{ secrets.DOCKERHUB_TOKEN }}
      -
        name: Build and push
        uses: docker/build-push-action@v2
        with:
          context: .
          platforms: linux/amd64,linux/arm64 # <---- here
          push: true
          tags: user/app:latest

@im2nguyen
Copy link
Owner

Oh! Then this is a dup of #50 😄

I created a PR for it, but waiting for additional features I'm planning on adding this weekend so I can cut a release next week with more than one feature

@murugaratham
Copy link
Author

I see, I'll close the issue and subscribe to #50 then, thanks for linking them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed Completed - pending requester to test
Projects
None yet
Development

No branches or pull requests

2 participants