Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not playing next item #170

Open
prydda opened this issue Feb 12, 2020 · 24 comments
Open

Not playing next item #170

prydda opened this issue Feb 12, 2020 · 24 comments
Labels
bug Something isn't working embycon Related to Embycon add-on question Further information is requested

Comments

@prydda
Copy link

prydda commented Feb 12, 2020

Using Embycon to playback and embuary skin.
I'm getting the popup to play next episode but it never does, it jumps back to current season.

logfile: http://ix.io/2bxL

@dagwieers
Copy link
Collaborator

The log is mostly empty. Did you enable debug logging?

@dagwieers dagwieers added the bug Something isn't working label Feb 12, 2020
@prydda
Copy link
Author

prydda commented Feb 12, 2020

Nope, sorry.
here is with debug activated:
https://del.dog/ygarfullyg

@dagwieers
Copy link
Collaborator

I don't know who wrote this dogbin service, but it is unusable in Chrome. Is it mining bitcoins perhaps?

How hard is it to create a service to show a text file in a browser without bringing the browser to a grinding halt. Sorry, try again.

@dagwieers
Copy link
Collaborator

Maybe you can attached it to this issue instead?

@prydda
Copy link
Author

prydda commented Feb 12, 2020

Not sure, used it for android logs. ix.io didn't work - I beileve the file was to large? (5.4mb)

here is a github gist: https://gist.github.com/prydda/4cd7c341cb0d235a8a0f49c621525435

@dagwieers
kodiUpNext.log

@dagwieers
Copy link
Collaborator

You can also attach it, see below: Attach files by dragging & dropping, selecting or pasting them.

@dagwieers
Copy link
Collaborator

dagwieers commented Feb 12, 2020

The only logged information from Up Next is receiving the information:

DEBUG: [service.upnext] Api -> addon_data_received called with data {u'play_info': {u'item_id': u'539893', u'auto_resume': False, u'force_transcode': False}, u'next_episode': {u'rating': 0.0, u'tvshowid': u'The Sunny Side Up Show', u'art': {u'tvshow.fanart': u'', u'thumb': u'https://emby.popcorney.xyz:443/emby/Items/539893/Images/Primary/0?Format=original&Tag=a0d62349704fd8a9c6de672f2236f06e|verifypeer=false', u'tvshow.clearart': u'https://emby.popcorney.xyz:443/emby/Items/539776/Images/Art/0?Format=original&Tag=|verifypeer=false', u'tvshow.landscape': u'', u'tvshow.poster': u'https://emby.popcorney.xyz:443/emby/Items/539776/Images/Primary/0?Format=original&Tag=6799c5baaaba14cd1567c7e1a8885320|verifypeer=false', u'tvshow.clearlogo': u''}, u'plot': None, u'season': 3, u'title': u'Vattnet g\xe5r', u'episodeid': u'539893', u'firstaired': None, u'episode': 10, u'playcount': 0, u'showtitle': u'The Sunny Side Up Show'}, 'id': u'embycon_play_action', u'current_episode': {u'rating': 0.0, u'tvshowid': u'The Sunny Side Up Show', u'art': {u'tvshow.fanart': u'', u'thumb': u'https://emby.popcorney.xyz:443/emby/Items/539892/Images/Primary/0?Format=original&Tag=b02a4c8f959d4fe78cf4ef0dd80db1d7|verifypeer=false', u'tvshow.clearart': u'https://emby.popcorney.xyz:443/emby/Items/539776/Images/Art/0?Format=original&Tag=|verifypeer=false', u'tvshow.landscape': u'', u'tvshow.poster': u'https://emby.popcorney.xyz:443/emby/Items/539776/Images/Primary/0?Format=original&Tag=6799c5baaaba14cd1567c7e1a8885320|verifypeer=false', u'tvshow.clearlogo': u''}, u'plot': u'DirectStream\nI Saltsj\xf6baden \xf6ppnar en kemtv\xe4tt som b\xe4r samma namn som Mickans och Freddes efternamn. N\xe4r Anna och Alex unders\xf6ker olika f\xf6rlossningsalternativ anklagar Anna Alex f\xf6r att vara en morsgris. Han f\xf6rs\xf6ker bevisa motsatsen men lyckas inte n\xe5got vidare.', u'season': 3, u'title': u'Kemtv\xe4tten', u'episodeid': u'539892', u'firstaired': 2012, u'episode': 9, u'playcount': 0, u'showtitle': u'The Sunny Side Up Show'}}

Which looks fine, but I see nothing else in the logs. Not even the notification itself, which is weird. I think we need to look at improving the default logging when debug logging is enabled.

I also see from the debug logs we can improve how we read the settings, this is suboptimal and makes the logs more chaotic.

@prydda
Copy link
Author

prydda commented Feb 13, 2020

kodi.log

I forgot put logging on from Up Next addon in the last log. Here is one with the same issue and debug on from Up Next - Settings - Expert - LogLevel Debug

@dagwieers
Copy link
Collaborator

Ok, so this Kodi log includes this line:

2020-02-13 14:12:35.695 T:3726914432   DEBUG: [service.upnext] Api -> Sending base64 data to add-on to play: {u'item_id': u'539896', u'auto_resume': False, u'force_transcode': False}

Which instructs the calling add-on to start playing the next episode. So we have 2 possibilities:

  • The data we send was incorrectly formatted (e.g. to work with Addon Signals)
  • The data we send was not received by the add-on correctly or timely (which may indicate an issue with Addon Signals or the add-on itself)

Since we have unit tests for the former problem testing Addon Signals, I doubt this is the case. It would be best if the add-on devs could investigate what is going on in their add-on.

  • Do they receive the info or not?
  • Is the info correctly formatted? (we return what they send)
  • Do they correctly and timely act on the response?

In v1.1.0 we added the possibility to have Up Next call the add-on directly to instruct it to play a specific episode, which is often more straightforward and easier. This would be something for the Embycon devs to consider.

@prydda
Copy link
Author

prydda commented Feb 13, 2020

@faush01 is there something you can do?

@dagwieers
Copy link
Collaborator

dagwieers commented Feb 13, 2020

For completeness, we think it is better to not require Addon Signals, as it adds unneeded complexity if the add-on already has a Monitor or Player instance. And with the new addition of play_url the add-on doesn't need to have this complexity. See: #133

I apologize for not having better documentation, we desperately need a rewrite of the documentation for developers. Things have become a lot easier nowadays.
Update: I rewrote the documentation in the wiki: https://github.com/im85288/service.upnext/wiki/Integration

@faush01
Copy link

faush01 commented Feb 13, 2020

The signals data approach should still work.

@dagwieers
Copy link
Collaborator

dagwieers commented Feb 13, 2020

Yes it should. But there is a known issue in the latest release. Not sure if it could be related.
ruuk/script.module.addon.signals#9

@prydda
Copy link
Author

prydda commented Feb 19, 2020

last night my other device (same OS - coreelec) and embycon plugin as playback content did actually play next episode from upnext addon as it should? - I will compare the settings and report back.

@dagwieers
Copy link
Collaborator

It would be nice to get to the bottom of this before we are releasing v1.1.1.
If it cannot be reproduced, I would rather close this issue until we can.

@dagwieers
Copy link
Collaborator

It is possible that #198 fixes also this issue. If this is easily reproduced at your end, please test out the fix in #198.
(You can download this zip and install it using the ZIP file)

@dagwieers dagwieers added the question Further information is requested label Jul 14, 2020
@dagwieers dagwieers added the embycon Related to Embycon add-on label Jul 28, 2020
@dagwieers
Copy link
Collaborator

So, I am sorry, I have no idea what Emby or Embycon exactly is so have a hard time to relate to the issue at hand.
But could it be related to a connection limit in Emby (one connection) as reported in issue #201 ?

@dagwieers
Copy link
Collaborator

Please test the upcoming v1.1.3 release by testing PR #217 and reporting back.

@sasagr
Copy link

sasagr commented Sep 13, 2021

I think I have a similar (if not the same) issue.
Here the log. https://paste.kodi.tv/ewuveborig
There is no error but it tells me that he cannot play next item.
This is happening if I play the current episode from the Next Up section within the embuary skin. If I play the episode from the season folder, it works fine.

UPDATE: reported the same issue in the skin kodi forum thread and got this reply from the embuary skin developer
https://forum.kodi.tv/showthread.php?tid=320137&pid=3060133#pid3060133

@MoojMidge
Copy link
Collaborator

Your issue is seemingly unrelated. What you are likely seeing is this issue: #255

Has been fixed but a new release needs to be pushed out.

@sasagr
Copy link

sasagr commented Sep 14, 2021

Your issue is seemingly unrelated. What you are likely seeing is this issue: #255

Has been fixed but a new release needs to be pushed out.

that's great news! but can I try it before it is pushed out? The link of the update you aded in the other issue, seems not be valid anymore

@MoojMidge
Copy link
Collaborator

You can download the latest code from this repository directly, but as you are using Kodi 19 you will either need to execute the makefile or modify the addon.xml file:

<import addon="xbmc.python" version="2.25.0"/>

So that it reads
<import addon="xbmc.python" version="3.0.0"/>

@cgwprs
Copy link

cgwprs commented Jan 1, 2023

I am having this issue "Not playing next item" with two addons, Seren and Asgard. Environment is Xubuntu 20.04, Kodi 19.5, current stable release of both addons. I will try to get a debug level log uploaded here today.

@MoojMidge
Copy link
Collaborator

This issue was about Embycon and, as far as I know, has been resolved.

If you are having issues with other video plugins, then a log is needed. That being said, I'm pretty sure none of the video plugins you mentioned support the use of Up Next, and instead handle playback of the next video themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working embycon Related to Embycon add-on question Further information is requested
Projects
None yet
Development

No branches or pull requests

6 participants