Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(version): Del manual job & fix concurrency #60 #66

Merged
merged 8 commits into from Sep 12, 2021
Merged

Conversation

imAsparky
Copy link
Owner

No description provided.

* Semantic Version updates were not working when a user merged an update
  into the main branch.
* The cause was a misunderstanding with the selected sem-ver package and
  its capabilities.
* Python-semantic-release has been implemented, with a config file and
  the relekang/python-semantic-release@master GitHub action.
* The setup.py, setup.cfg and sphinx conf.py files now use the
  __version__ style recommended by python-semantic-release.
* requirements_dev.txt now includes python-semantic-release for local
  checks using --noop.
* Automatic-Changelog workflows updates match semantic_release.yaml
  config files.

WIP #60
setup.cfg has a typo in version_variable =
setup.py:version, docs/source/conf.py:version
, docs should be ,docs

WIP #60
python-semantic-release was failing due to check_build_status = true.
False is the default setting.

WIP #60
Manually running Semantic Release workflow was not possible.

WIP #60
* Manually running Semantic Release workflow was not working due to the
  if: github.event.pull_request.merged == true condition.
* Added an extra job for workflow_dipatch and a workflow concurrency
  group to prevent Semantic Release jobs from running in parallel and
  causing mischief.

WIP #60
* After starting pull request #65, I realised  I had made an error in
  adding the additional workflow.
* The manual workflow is now part of the
  if: github.event.pull_request.merged == true conditional
* I moved the concurrency condition due to having incorrect indentation.

WIP #60
@imAsparky imAsparky added the bug Something isn't working label Sep 12, 2021
@imAsparky imAsparky self-assigned this Sep 12, 2021
@imAsparky imAsparky added this to In progress in Modify the original fork to suit my needs via automation Sep 12, 2021
@imAsparky imAsparky enabled auto-merge (squash) September 12, 2021 07:24
@imAsparky imAsparky merged commit 6e1c1ca into main Sep 12, 2021
Modify the original fork to suit my needs automation moved this from In progress to Done Sep 12, 2021
@imAsparky imAsparky deleted the issue-60 branch September 12, 2021 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

None yet

1 participant