Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed jobs not handled correctly #63

Closed
0x4c6565 opened this issue Oct 16, 2020 · 1 comment · Fixed by #64
Closed

Failed jobs not handled correctly #63

0x4c6565 opened this issue Oct 16, 2020 · 1 comment · Fixed by #64

Comments

@0x4c6565
Copy link
Contributor

It would appear that failing a job via $this->fail() also causes JobProcessed event to be raised, overriding the failed status set when handling the previous JobFailed event.

I will submit a PR to rework the DefaultEventManager class to handle this
@0x4c6565 0x4c6565 mentioned this issue Oct 16, 2020
Merged
@o15a3d4l11s2 o15a3d4l11s2 mentioned this issue May 13, 2021
Open
@ansien
Copy link

ansien commented Feb 16, 2022 •
edited

@imTigger Hey, any update on this one? Seems to be happening a lot here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rework DefaultEventManager to handle failed jobs 0x4c6565/laravel-job-status
2 participants
@ansien @0x4c6565