Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide better error messages for payroll errors #7455

Closed
jniles opened this issue Feb 1, 2024 · 0 comments · Fixed by #7520
Closed

Provide better error messages for payroll errors #7455

jniles opened this issue Feb 1, 2024 · 0 comments · Fixed by #7520

Comments

@jniles
Copy link
Contributor

jniles commented Feb 1, 2024

Scenario

We had a case where two employee configurations were incorrect, and Vanga attempted to pay payroll. The system crashed with a generic error message (a NOT NULL error). After locating the issue with the employee in the database logs, we fixed that employee, but the users reported that the system still crashed.

In reality, we had fixed one employee, but were missing the second one. Had the users realized this, they might have been able to continue working by fixing the second employee.

Proposal

I propose we need better error messages for payroll crashes. We currently have everything in a database transaction, which is good, but we still need to keep some sort of log that to say "system crashed when processing employee jniles". That would provide some guidance to the user that something is wrong with employee jniles configuration. If we had this error message (instead of a NOT NULL error), there is a chance the payroll issues at Vanga would have worked themselves out yesterday without as much manual intervention from the team.

@lomamech lomamech self-assigned this Feb 28, 2024
lomamech added a commit to lomamech/bhima-2.X that referenced this issue Feb 29, 2024
- Prevent entry into the database of items whose values are not defined
- Display of the name of the employee for whom the Payroll data configuration was incorrect

closes IMA-WorldHealth#7455
lomamech added a commit to lomamech/bhima-2.X that referenced this issue Feb 29, 2024
- Prevent entry into the database of items whose values are not defined
- Display of the name of the employee for whom the Payroll data configuration was incorrect

closes IMA-WorldHealth#7455
lomamech added a commit to lomamech/bhima-2.X that referenced this issue Mar 1, 2024
- Prevent entry into the database of items whose values are not defined
- Display of the name of the employee for whom the Payroll data configuration was incorrect

closes IMA-WorldHealth#7455
lomamech added a commit to lomamech/bhima-2.X that referenced this issue Mar 4, 2024
- Prevent entry into the database of items whose values are not defined
- Display of the name of the employee for whom the Payroll data configuration was incorrect

closes IMA-WorldHealth#7455
lomamech added a commit to lomamech/bhima-2.X that referenced this issue Mar 4, 2024
- Prevent entry into the database of items whose values are not defined
- Display of the name of the employee for whom the Payroll data configuration was incorrect

closes IMA-WorldHealth#7455
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants