-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to rotate the RadarChart titles #1057
Add the ability to rotate the RadarChart titles #1057
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1057 +/- ##
==========================================
+ Coverage 86.24% 86.32% +0.08%
==========================================
Files 45 45
Lines 2777 2808 +31
==========================================
+ Hits 2395 2424 +29
- Misses 382 384 +2
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Everything is good and Approved. But before merging please do the below requirements.
Thanks in advance! |
ae585ac
to
c278d96
Compare
Ok, I added some doc as you asked I'm not sure if it's enough or too much. |
I think it's better to move your images beside the migration file. Because they are fully related to the migration file (in images/*_chart/ we put images that have a corresponding implementation in our example app). |
c278d96
to
4d9e1fd
Compare
Yes seems better to me to avoid flooding the example image folder. I moving all of this. |
4d9e1fd
to
1c479f6
Compare
Thank you! |
It was a straightforward PR. |
Just one question :
Do we need to update the Markdown radar chart doc with more detailed information about the need behavior of the
RadarChartData.getTitle
fieldMaybe the migration doc too