Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom zero line width #22

Closed
jstuth opened this issue Jun 13, 2019 · 18 comments
Closed

Custom zero line width #22

jstuth opened this issue Jun 13, 2019 · 18 comments
Labels
enhancement New feature or request

Comments

@jstuth
Copy link
Contributor

jstuth commented Jun 13, 2019

Is it possible to add a custom zero line width parameter to the FlGridData wich would render the zero line a bit more prominent.

I currently stack my chart and draw a thicker divider using positioned widget to simulate that. But it is not very handy for dynamic charts.

Edit: oh and, is there a built in way to set a custom background color for the chart? Currently i use the stack approach described above.

@imaNNeo
Copy link
Owner

imaNNeo commented Jun 13, 2019

Good odea,
In the 0.0.7 version we have ExtraLines in LineChartData to draw some straight lines on the chart, you can use them until we add this feature.
Thanks!

@imaNNeo imaNNeo added the enhancement New feature or request label Jun 13, 2019
@jstuth
Copy link
Contributor Author

jstuth commented Jun 13, 2019

You're welcome :)
Thank you for this awesome library

@imaNNeo
Copy link
Owner

imaNNeo commented Jun 13, 2019

Yhank you too,
It's my pleasure :)

@jstuth
Copy link
Contributor Author

jstuth commented Jun 13, 2019

I tried the ExtraLine feature and it is a much better approach! Thank you for the tip!

@jstuth
Copy link
Contributor Author

jstuth commented Jun 13, 2019

Do you have a feature to add a custom color as a grid background?

@imaNNeo
Copy link
Owner

imaNNeo commented Jun 13, 2019

Yes its a good approach
, by the way we shoudl have a customizable background grid.

@imaNNeo
Copy link
Owner

imaNNeo commented Jun 13, 2019

What do you mean?

@jstuth
Copy link
Contributor Author

jstuth commented Jun 13, 2019

I mean, a color which is used as a background color for the grid. Which is drawn inside the border.

@jstuth
Copy link
Contributor Author

jstuth commented Jun 13, 2019

Currently i use a container with a color and stack the chart on top. Using a positioned widget i can align my container with the chart.

Simulator Screen Shot - iPhone Xs - 2019-06-13 at 19 36 25

@imaNNeo
Copy link
Owner

imaNNeo commented Jun 13, 2019

Aha got it,
Sure we can but this is low priority,
I'm trying to add interactivity to all charts, and I have to focus on it,
But don't worry we can have this ASAP,
I ask you if you are interested to contribute and have enought time, let's add it and make your PR,
But before that if you were intrested to do that let me know to talking about how implement it

@jstuth
Copy link
Contributor Author

jstuth commented Jun 13, 2019

Sure, i'm interested to contribute on that topic.

@imaNNeo
Copy link
Owner

imaNNeo commented Jun 13, 2019

Great
Take a look on the code.

@jstuth
Copy link
Contributor Author

jstuth commented Jun 13, 2019

i already did and already implemented a way. How do we discuss my thoughts without spamming this issue?
I never contributed on a github project so far...

@imaNNeo
Copy link
Owner

imaNNeo commented Jun 13, 2019

I think we can chat on twitter or whatsapp or telegram, which one you prefer?

@jstuth
Copy link
Contributor Author

jstuth commented Jun 13, 2019

I've sent you an email to you gmail. Let's start with that for now.

@houqinzhe
Copy link

study

@imaNNeo
Copy link
Owner

imaNNeo commented Jun 14, 2019

@houqinzhe what?

@imaNNeo
Copy link
Owner

imaNNeo commented Jun 14, 2019

added in 0.0.8,
check it out
cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants