Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent line curvature overshooting #25

Closed
stx opened this issue Jun 15, 2019 · 7 comments
Closed

Prevent line curvature overshooting #25

stx opened this issue Jun 15, 2019 · 7 comments
Labels
enhancement New feature or request

Comments

@stx
Copy link

stx commented Jun 15, 2019

Thanks for this plugin. It's really fantastic and you're really killing it!

I love the curved lines, but they cause data confusion due to "overshooting" their data point. Changing curvature smoothness doesn't seem to fix this specific issue.

Flat:

image

Curved:

image

Becomes especially problematic if you see the actual data points:

image

Can we do something like this crummy Photoshop job?

image

Basically, keep curvature, but prevent overshooting?

@imaNNeo
Copy link
Owner

imaNNeo commented Jun 15, 2019

Hi, pleasure is mine.
Thats a bad issue,
I will find a solution ASAP
Thanks for report!

@imaNNeo imaNNeo added the enhancement New feature or request label Jun 15, 2019
@imaNNeo
Copy link
Owner

imaNNeo commented Jul 6, 2019

did you try to set curveSmoothness less than 0.35?
(the default value is 0.35, you can decrease it)

@stx
Copy link
Author

stx commented Jul 6, 2019

Yes, doesn’t have the same effect. I want curves, just not overshooting curves. Thank you!

@imaNNeo
Copy link
Owner

imaNNeo commented Jul 6, 2019

Yes it doesn't have the same effect, but can be used as temporary solution, until I will be free to work on it.

@imaNNeo imaNNeo closed this as completed in dba523e Jul 7, 2019
@imaNNeo
Copy link
Owner

imaNNeo commented Jul 7, 2019

fixed on 0.1.2, added preventCurveOverShooting on LineChartBarData

preventCurveOverShooting = false

preventCurveOverShooting = true

@imaNNeo
Copy link
Owner

imaNNeo commented Jul 7, 2019

It would be nice if you share the result on your sample here

@jamesblasco
Copy link
Contributor

Thanks for this! It's awesome, but while almost all of my graphs works well there are some that with preventCurveOverShooting = true looks like this (see the right side)
IMG_1828

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants