feat(radar-chart): Add minimum/maximum value overrides #1091

zmeggyesi · 2022-07-08T11:05:29Z

New values are not required, will fall back to previous functionality if omitted.

New values are not required, will fall back to previous functionality if omitted. issue-id: imaNNeo#1090

zmeggyesi · 2022-07-08T11:07:19Z

@imaNNeoFighT Pubspec intentionally left untouched, in case you want to step versions according to your own schedule.

lib/src/chart/radar_chart/radar_chart_painter.dart

I neglected the fact that points on the chart are scaled according to the max value in the dataset, not necessarily the provided the max value, which caused an offset in the drawn chart. issue-id: imaNNeo#1090

codecov · 2022-07-24T19:56:02Z

Codecov Report

Merging #1091 (7c3561b) into master (b5f469d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 7c3561b differs from pull request most recent head 1cd9f7e. Consider uploading reports for the commit 1cd9f7e to get more accurate results

@@           Coverage Diff           @@
##           master    #1091   +/-   ##
=======================================
  Coverage   86.19%   86.20%           
=======================================
  Files          45       45           
  Lines        2826     2828    +2     
=======================================
+ Hits         2436     2438    +2     
  Misses        390      390

Impacted Files	Coverage Δ
lib/src/chart/radar_chart/radar_chart_painter.dart	`100.00% <100.00%> (ø)`
...ib/src/chart/radar_chart/radar_chart_renderer.dart	`100.00% <100.00%> (ø)`

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

lib/src/chart/radar_chart/radar_chart_data.dart

imaNNeo · 2022-08-03T16:47:27Z

BTW You need to write some unit-tests to pass the codecov pipeline

Make the new values non-nullable, and add some calculation logic based on imaNNeoFighT's suggestions issue-id: imaNNeo#1090

issue-id: imaNNeo#1090

lib/src/chart/radar_chart/radar_chart_data.dart

Caused a lot of code displacement, making the diff nearly-unreadable issue-id: imaNNeo#1090

issue-id: imaNNeo#1090

Also removes a `dynamic`-related type error

lib/src/chart/radar_chart/radar_chart_painter.dart

imaNNeo · 2022-08-09T19:33:56Z

Something is wrong with your code style.
Please run make format and make analyze to see what's wrong.

…feedback

zmeggyesi · 2022-08-12T11:20:20Z

Sorry for the delay. I've cleaned up those orphaned variables and acted on the Analyzer warnings. I've also pulled the latest master, just to be on the safe side of things.

imaNNeo · 2022-09-04T13:32:24Z

lib/src/chart/radar_chart/radar_chart_renderer.dart

@@ -37,7 +37,9 @@ class RenderRadarChart extends RenderBaseChart<RadarTouchResponse> {
      : _data = data,
        _targetData = targetData,
        _textScale = textScale,
-        super(targetData.radarTouchData, context);
+        super(targetData.radarTouchData, context) {
+    painter = RadarChartPainter();


What is this painter?

imaNNeo · 2023-01-15T12:32:21Z

Any update?

zmeggyesi · 2023-01-17T12:55:01Z

Sorry, I haven't had the bandwidth to fix the CC issue yet. I'll see what I can do in the near future. Sent from phone, please excuse brevity (and possible typos).

…

On Sun, Jan 15, 2023, 12:32 Iman Khoshabi ***@***.***> wrote: Any update? — Reply to this email directly, view it on GitHub <#1091 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD34O3XFCY7FMVOCAW2JAHTWSPU6BANCNFSM53AT2C2Q> . You are receiving this because you authored the thread.Message ID: ***@***.***>

eldrig0 · 2024-01-12T14:14:01Z

Is this feature implemented?

imaNNeo · 2024-01-22T18:54:51Z

We had a similar fix here: #1293

feat(radar-chart): Add minimum/maximum value overrides

167aa4c

New values are not required, will fall back to previous functionality if omitted. issue-id: imaNNeo#1090

ateich reviewed Jul 9, 2022

View reviewed changes

lib/src/chart/radar_chart/radar_chart_painter.dart Outdated Show resolved Hide resolved

fix(radar-chart): fix newly-introduced scaling bug

786b60f

I neglected the fact that points on the chart are scaled according to the max value in the dataset, not necessarily the provided the max value, which caused an offset in the drawn chart. issue-id: imaNNeo#1090

chore (formatting): run dartfmt for consistency

571e9f3

imaNNeo reviewed Aug 3, 2022

View reviewed changes

lib/src/chart/radar_chart/radar_chart_data.dart Outdated Show resolved Hide resolved

zmeggyesi added 2 commits August 4, 2022 16:09

chore(cr): implement CR feedback

5bb41a7

Make the new values non-nullable, and add some calculation logic based on imaNNeoFighT's suggestions issue-id: imaNNeo#1090

chore(cr): fix a minor typo that bothered my eyes

e67fe52

issue-id: imaNNeo#1090

imaNNeo reviewed Aug 4, 2022

View reviewed changes

lib/src/chart/radar_chart/radar_chart_data.dart Outdated Show resolved Hide resolved

imaNNeo reviewed Aug 4, 2022

View reviewed changes

lib/src/chart/radar_chart/radar_chart_data.dart Outdated Show resolved Hide resolved

zmeggyesi added 5 commits August 5, 2022 12:44

chore(cr): revert accidental formatting

3be8d92

Caused a lot of code displacement, making the diff nearly-unreadable issue-id: imaNNeo#1090

chore(cr): fix naming mistake

c5e88b3

issue-id: imaNNeo#1090

chore (formatting): rerun dart format based on workflow failure

09296cb

Merge branch 'master' of https://github.com/imaNNeoFighT/fl_chart

9c725cc

chore(cr): update with latest source master

7c3561b

Also removes a `dynamic`-related type error

zmeggyesi mentioned this pull request Aug 8, 2022

Feature - RadarChart Max value #995

Closed

imaNNeo reviewed Aug 9, 2022

View reviewed changes

lib/src/chart/radar_chart/radar_chart_painter.dart Outdated Show resolved Hide resolved

zmeggyesi added 4 commits August 12, 2022 13:13

Merge remote-tracking branch 'source/master'

073ec4e

chore(cr): update with latest source master and implement further CR …

9d77b52

…feedback

chore(cr): rerun formatter

71e9eb1

chore(cr): act on Analyzer warnings

1cd9f7e

imaNNeo reviewed Sep 4, 2022

View reviewed changes

imaNNeo closed this Nov 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(radar-chart): Add minimum/maximum value overrides #1091

feat(radar-chart): Add minimum/maximum value overrides #1091

zmeggyesi commented Jul 8, 2022 •

edited by imaNNeo

zmeggyesi commented Jul 8, 2022

codecov bot commented Jul 24, 2022 •

edited

imaNNeo commented Aug 3, 2022

imaNNeo commented Aug 9, 2022

zmeggyesi commented Aug 12, 2022

imaNNeo Sep 4, 2022

imaNNeo commented Jan 15, 2023

zmeggyesi commented Jan 17, 2023 via email

eldrig0 commented Jan 12, 2024

imaNNeo commented Jan 22, 2024

feat(radar-chart): Add minimum/maximum value overrides #1091

feat(radar-chart): Add minimum/maximum value overrides #1091

Conversation

zmeggyesi commented Jul 8, 2022 • edited by imaNNeo

zmeggyesi commented Jul 8, 2022

codecov bot commented Jul 24, 2022 • edited

Codecov Report

imaNNeo commented Aug 3, 2022

imaNNeo commented Aug 9, 2022

zmeggyesi commented Aug 12, 2022

imaNNeo Sep 4, 2022

Choose a reason for hiding this comment

imaNNeo commented Jan 15, 2023

zmeggyesi commented Jan 17, 2023 via email

eldrig0 commented Jan 12, 2024

imaNNeo commented Jan 22, 2024

zmeggyesi commented Jul 8, 2022 •

edited by imaNNeo

codecov bot commented Jul 24, 2022 •

edited