Allow tooltip rotation and improve alignment of rotated elements #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The background colour when rotate still seems off To reproduce |
|
Thanks for testing, I'll reopen the pull request when that's fixed. |
|
@martinkong0806 the background problem when rotating the tooltips should be fixed with my latest changes: |
imaNNeo
reviewed
May 28, 2021
|
@martinkong0806 Thanks for testing! |
|
@josh-ksr Everything looks good and amazing. I think everyone is going to love it. |
imaNNeo
reviewed
May 28, 2021
imaNNeo
reviewed
May 28, 2021
This was referenced Jun 17, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes it is possible to rotate tooltips (#260).
I also changed the alignment of rotated elements, so that all rotated elements have the same distance to the chart.
Rotated Tooltips:
Alignment including these changes:
For comparison: Alignment of rotated elements before, without these changes:
