-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dialog Fragment #2
Comments
The library uses Activity's decor view to place the target view on top of everything but Dialogs in Android are shown creating another Window above current the current one. |
I made my own implementation but I didn't tested it very well. |
Feel free to make a pull request then. |
Have you overcome this issue? |
Do you have a solution for this yet? Rather important to have this working if I'm to use it in our project. |
@ZachBublil @LawrenceStent Sorry but I have no time right now to handle any issues. @TurKorsaN mentioned that he managed to resolve it, so maybe he can offer some help |
It's fine I changed my implementation to the of a normal fragment. If anyone else is looking at this then this is an option, however having a zoom on a dialog may not be possible with this library. |
Hi everyone I managed to solve the issue partially by drawing the zoomed View over the Dialog's window, but because of the nature of them, depending on their window configuration, they may be drawn on not-full screen windows, so the zoomed View will never scale over the whole screen in these cases. Fullscreen Dialogs tested works well. |
I have faced the same problem |
Hi @akshitpsutariya you should be able to construct the Zoomy builder with a Dialog instance to get the decor view from its Window. |
When using in DialogFragment, ZoomableView stays under DialogFragment. And i can't see the image.
The text was updated successfully, but these errors were encountered: