Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog Fragment #2

Closed
TurKorsaN opened this issue Apr 25, 2017 · 10 comments
Closed

Dialog Fragment #2

TurKorsaN opened this issue Apr 25, 2017 · 10 comments

Comments

@TurKorsaN
Copy link

When using in DialogFragment, ZoomableView stays under DialogFragment. And i can't see the image.

@imablanco
Copy link
Owner

The library uses Activity's decor view to place the target view on top of everything but Dialogs in Android are shown creating another Window above current the current one.
I will try to figure out how to resolve this issue.
If someone has any idea how to deal with this any help will be appreciated.

@TurKorsaN
Copy link
Author

I made my own implementation but I didn't tested it very well.

@imablanco
Copy link
Owner

Feel free to make a pull request then.

@Zachinio
Copy link

Zachinio commented Apr 8, 2018

Have you overcome this issue?

@LawrenceStent
Copy link

Do you have a solution for this yet? Rather important to have this working if I'm to use it in our project.

@imablanco
Copy link
Owner

@ZachBublil @LawrenceStent Sorry but I have no time right now to handle any issues. @TurKorsaN mentioned that he managed to resolve it, so maybe he can offer some help

@LawrenceStent
Copy link

It's fine I changed my implementation to the of a normal fragment. If anyone else is looking at this then this is an option, however having a zoom on a dialog may not be possible with this library.

imablanco pushed a commit that referenced this issue Aug 3, 2018
@imablanco
Copy link
Owner

Hi everyone I managed to solve the issue partially by drawing the zoomed View over the Dialog's window, but because of the nature of them, depending on their window configuration, they may be drawn on not-full screen windows, so the zoomed View will never scale over the whole screen in these cases. Fullscreen Dialogs tested works well.

@akshitpsutariya
Copy link

The library uses Activity's decor view to place the target view on top of everything but Dialogs in Android are shown creating another Window above current the current one.
I will try to figure out how to resolve this issue.
If someone has any idea how to deal with this any help will be appreciated.

I have faced the same problem

@imablanco
Copy link
Owner

Hi @akshitpsutariya you should be able to construct the Zoomy builder with a Dialog instance to get the decor view from its Window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants