Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish version including miniz_oxide update #272

Closed
atouchet opened this issue Dec 10, 2020 · 5 comments · Fixed by #300
Closed

Publish version including miniz_oxide update #272

atouchet opened this issue Dec 10, 2020 · 5 comments · Fixed by #300

Comments

@atouchet
Copy link
Contributor

Currently image has duplicate dependencies of both miniz_oxide 0.3 and 0.4 due to the png and the tiff crates. It appears it was updated in 4424245 but this isn't included in the latest release. Can a new release be made with this commit?

@atouchet
Copy link
Contributor Author

atouchet commented Dec 10, 2020

Hmm, looking at a linked comment it says miniz_oxide 0.4 isn't compatible with Rust 1.34.2. Is that still the case?

@HeroicKatora
Copy link
Member

I'm not aware of functional changes of 0.4 compared to 0.3. The main reason for 0.4 in the first place was inclusion into the Rust compiler architecture, and subsequent releases to detect the compiler version to restore compatibility with 1.34.2 again. That being said, it likely does duplicate some amount of code which might cause slight bloat. It's not critical enough to warrant an immediate release but a backport PR would be fine.

@complexspaces
Copy link

Hi there,

I noticed this issue has been quiet for a bit, but it was mentioned in this PR as something that was getting closer. Are there any updates here by chance?

@fintelia
Copy link
Contributor

fintelia commented Jul 1, 2021

I think it is probably time to go ahead and publish a new release

@ldm0
Copy link

ldm0 commented Jul 18, 2021

I think it is probably time to go ahead and publish a new release

Any update? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants