Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No method to get xoffset/yoffset from SubImage after deprecating bounds() in #2036 #2118

Closed
brykgroup-andrews opened this issue Jan 30, 2024 · 1 comment · Fixed by #2126
Closed

Comments

@brykgroup-andrews
Copy link
Contributor

As of 0.25.0, specifically in MR #2036, the ::bounds(&self) method has been deprecated. But there has been no way to get the x and y offsets out of that view since that deprecation - is there any way that something can be reintroduced alongside the newly minted ::dimentions(&self) call?

In my case, I use it in a ::change_bounds() call in order to shift the bounds around by a relative margin.

@fintelia
Copy link
Contributor

fintelia commented Feb 1, 2024

Yeah, removing access to the offsets wasn't intentional. Please feel free to make a PR adding a method on SubImage to access them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants