-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compression to PNG #390
Comments
Shouldn't the zlib/deflate encoders/decoders be extracted into their own library? |
That would be the optimal solution. I just put this up to document it somewhere else than in some PR comments. |
I wonder if we shouldn’t just use flate2 for compression and decompression… |
😢 😭 |
I would be very happy keep the pure Rust solution. But writing a zlib en-/decoder is hard work. I tried both ours, the one from #99 and the one from alexcrichton/rust-compress. They all have bugs. If we are lucky they are easy to fix. I didn’t succeed. |
I don't think it's that hard to write. |
@nwin fixing rust-compress would be nice, if it's failing. We need to add your case as a test. |
@tomaka not hard but tedious |
Closing in favor of #419. |
The ability to compress PNG images was reduced in order to make it work with Rust 1.0 beta that should be added back at some point…
The text was updated successfully, but these errors were encountered: