-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial crate release #18
Comments
I've added pub type VecBuffer<P: Pixel> = ImageBuffer<P, Vec<P::Subpixel>>; to my fork of this crate, which lets me tidy a lot of noise from function signatures. However, it also produces a (spurious in this case) compiler warning. I'm not sure whether the extra neatness is worth adding a compiler warning. Ideally I'd like to just disable the warning in this one place, but I can't see how I'd do that. |
Function signatures are now looking a bit nicer: #19 |
looking forward to this being a published crate |
I was holding off on publishing because I expect everything to be very unstable for a while and didn't want to annoy everyone with constant breaking changes. However, if there's demand for this to be in cargo (with the understanding that breaking changes are highly likely) then I can publish this weekend. |
I just started exploring the landscape of image processing options in (stable) rust on crates.io. I found and started working with your image crate but the image ops provided were pretty minimal. I was looking for gradient color map support. I saw there was a color map option in that crate but it wasn't clear how to map or create gradients. That's how I happened to stumble on this repo. I wouldn't mind the breaking changes in pre 1.0 releases. I'd expect them! As that would be the time users can try things out and learn what feels right and what feels wrong :) |
Ok, cool. One stumbling block is that this library currently only builds on nightly rust. I've created #83 to fix this, and I'll have a look at this soon. |
BTW @softprops, what do you mean by gradient colour maps? Googling produced a few mentions of photoshop, but no definitions I could see. |
I've added @bvssvni as a crate owner. |
nice! |
@theotherphil here's a link that may help describe what im trying to figure out how to do http://www.imagemagick.org/Usage/color_mods/#duotone The idea is to take an image, grayscale it, create a 2 color gradient and somehow map those colors to the grayscale creating a duotone effect. |
Thanks, makes sense. I assume you're after something matching what ImageMagick can do, and I've created #96. If this isn't quite what you were after then please comment there. |
Thanks. Will do! |
I added the PistonCollaborator team as owners on crates.io. Updated Piston overview on the wiki. Imageproc is now listed under "Standalone libraries". |
Great, thanks! |
We don't have to make this polished, just less rough than the code is now.
Try to reduce signature bloat a little. Unfortunately I think we're stuck with the I: 'static, I::Pixel: 'static, <I::Pixel as Pixel>::Subpixel: + 'static spam for now (but I'd be very happy to be shown wrong).Make the existing functions nicer to call, probably with a mix of functions taking loads of options and functions providing sensible defaults for some of those options that forward to the verbose ones.Stop spamming everything directly into master. I'll create a fork and move my future commits to go via pull requests.Set up continuous integration. Anyone want to help with this one?Better readme - give usage examples, and briefly discuss future plans and how to contribute.Add a license.Build on stable.The text was updated successfully, but these errors were encountered: