Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pure Python ico/png #62

Closed
almarklein opened this issue Jan 30, 2015 · 4 comments
Closed

Pure Python ico/png #62

almarklein opened this issue Jan 30, 2015 · 4 comments

Comments

@almarklein
Copy link
Member

almarklein commented Jan 30, 2015

I have code in zoof Flexx that can read/write ICO, BMP, PNG in pure Python. Limited to RGB(A) though. But might be interesting to not need freeimage for png. And also for #21

@almarklein
Copy link
Member Author

Need increases, because the current freeimage-based ico implementation segfaults on Travis on 3.5.

Edit: This was for a specific Travis run. Not sure, why, and it indicates that ICO is currently unstable, but not 3.5 specific.

@almarklein
Copy link
Member Author

The cases for which this makes sense is either people who have somehow managed to install imageio without pillow, or people who need good ico support, in which case its probably related to some sort of app, which can include other code (e.g. https://github.com/zoofIO/flexx/blob/master/flexx/util/icon.py). Either way, adding such functionality at this point does not seem to benefit much, and costs extra weight to imageio, plus extra maintenance.

Therefore, wont do this unless the need for it increases for some reason.

BTW: Pillow can export icons but reading only gives largest image.

@FirefoxMetzger
Copy link
Contributor

@almarklein This is an old issue flagged as wontfix. Revisiting this after 5 years, do you think anything has changed regarding your decision? I.e., do we still think that not adding this is the best solution?

If so, I suggest we close this issue to stay organized :)

@almarklein
Copy link
Member Author

If Pillow stays a hard dependency the need for this is indeed quite low. Let's close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants