Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Python 3.11 #920

Merged
merged 4 commits into from
Dec 17, 2022
Merged

Add support for Python 3.11 #920

merged 4 commits into from
Dec 17, 2022

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Dec 14, 2022 •
edited

Python 3.11 was released on 2022-10-24 馃殌

image

@FirefoxMetzger
Copy link
Contributor

Thanks for updating setup.py. Let me know when you are happy with the PR and I will review :)

@hugovk
Copy link
Contributor Author

hugovk commented Dec 15, 2022

Ready for review!

FirefoxMetzger
FirefoxMetzger approved these changes Dec 17, 2022
View reviewed changes
Copy link
Contributor

@FirefoxMetzger FirefoxMetzger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I've added some plumbing to pick a pyav version that is compatible with the python version being used. (av==10.0.0 stopped reading some metadata, so those tests fail; however, we need it to enable testing on python 3.11)

@FirefoxMetzger FirefoxMetzger merged commit e4146a1 into imageio:master Dec 17, 2022
@hugovk hugovk deleted the add-3.11 branch December 17, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FirefoxMetzger FirefoxMetzger FirefoxMetzger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hugovk @FirefoxMetzger