Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tifffile plugin #97

Closed
kuchi opened this issue Jul 4, 2015 · 4 comments
Closed

tifffile plugin #97

kuchi opened this issue Jul 4, 2015 · 4 comments

Comments

@kuchi
Copy link
Contributor

kuchi commented Jul 4, 2015

Add tifffile plugin for better tiff file support.

@kuchi
Copy link
Contributor Author

kuchi commented Jul 4, 2015

@Zulko & @blink1073 what would be the best approach for this plugin?

  1. Should a thin wrapper be made around the pypi tifffile package and then tifffile added as a dependency for imageio? It could be an optional dependency and if tifffile is not installed then it could gracefully not load the thin wrapper.
  2. Or should the code for tifffile be included in imagio.

I guess the risk of 1 is if tifffile gets updated and is not backwards compatible it could cause problems. But the downside is if updates are made to improve it then the user gets them and imageio does not lag behind. In fact, it looks like tifffile was updated recently.

The other advantage of 1 is imageio is pure python. Tifffile has some c code (although I think tifffile can gracefully fail and use a pure python implementation) . Having imageio import optionally import tifffile keeps imageio pure python.

@blink1073
Copy link
Member

I have already started work on the tifffile plugin. My vote would be to include a current snapshot of the pure python part of tifffile and use that if a system version is not found.

@blink1073
Copy link
Member

PR is in #98. This is also a duplicate of #30.

@almarklein
Copy link
Member

Closing as duplicate of #30

(I also think the source code should go in imageio)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants