Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table API change: require unique column headers #25

Closed
ctrueden opened this issue Jul 27, 2014 · 1 comment
Closed

Table API change: require unique column headers #25

ctrueden opened this issue Jul 27, 2014 · 1 comment

Comments

@ctrueden
Copy link
Member

In IJ1 the ResultsTable API deprecates accessing arbitrary cell values by (col,row). All data access is meant to work by (columnName,row).

Currently IJ2 allows unnamed columns (or even two columns with the same name). We should change the table API to allow them to index via column name rather than column number. And we should put in checks so that setting column headers only allows unique column names (they could default to "1", "2", "3", etc.).

These changes would allow us to simplify the code in ResultsTableHarmonizer and also make it more correct.

Migrated-From: http://trac.imagej.net/ticket/1601

@ctrueden
Copy link
Member Author

The Table API moved to https://github.com/scijava/scijava-table. The API is stable and unlikely to change in the near future. There will be a scijava-table2 eventually which fixes various things such as using composition over inheritance w.r.t. the Java collections interfaces. But I am not convinced unique column header names is indeed something we want to enforce, even in the next incarnation of the API.

@ctrueden ctrueden closed this as not planned Won't fix, can't repro, duplicate, stale Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant