Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer a smart filter in the Manage Update Sites dialog #62

Closed
acardona opened this issue May 8, 2017 · 3 comments
Closed

Offer a smart filter in the Manage Update Sites dialog #62

acardona opened this issue May 8, 2017 · 3 comments

Comments

@acardona
Copy link
Member

acardona commented May 8, 2017

It is kind of hard to discover which update sites provide which plugins or which java classes from a e.g. library. A search at the top of the table for Update Sites could filter the contents of the table to only those update sites with matching text, which ideally would be the name of the plugin or the name of a java class included in the update site jars.

Unzipping jar files in memory, or rather, listing their contents, to extract class names that contain an underscore, is doable. I'd extract all non-anonymous class file names anyway for filtering, so that libraries could be inspected in the same way. An iterative piece of code to do this is not hard (I've written one: 65 lines long in java [about 15 near the top are the relevant code], https://github.com/trakem2/TrakEM2/blob/master/TrakEM2_/src/main/java/ini/trakem2/Project.java#L129 ). Adapting mine or creating a new one would not be much work.

@acardona acardona changed the title Fiji's update sites are so long that a filtering option is needed in the UI Fiji's update sites are so numerous that a filtering option is needed in the UI May 8, 2017
@ctrueden
Copy link
Member

ctrueden commented May 8, 2017

I agree this would be nice. No time this year, though. Feel free to file a PR in the meantime.

@ctrueden ctrueden added this to the unscheduled milestone May 8, 2017
@ctrueden
Copy link
Member

ctrueden commented May 8, 2017

Also, note that the relevant repository for the UI portion of this work would be https://github.com/imagej/imagej-ui-swing. Though I'd suggest implementing the filter itself as part of a core service in this component, to ease creation of other updater UIs in the future.

@ctrueden ctrueden changed the title Fiji's update sites are so numerous that a filtering option is needed in the UI Offer a smart filter in the Manage Update Sites dialog May 8, 2017
@NicoKiaru
Copy link
Contributor

I think this was finally done thanks to @tferr in imagej/imagej-ui-swing#91

Closing. Please re-open if I missed something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants