/
1096.html
302 lines (269 loc) · 8.77 KB
/
1096.html
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<!-- See: http://trac.edgewall.org/wiki/TracInterfaceCustomization -->
<head>
<title>
#1096 (SaltAndPepper issue)
– ImageJ
</title>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
<link rel="stylesheet" href="trac.css" type="text/css" /><link rel="stylesheet" href="ticket.css" type="text/css" /><link rel="stylesheet" href="tracvote.css" type="text/css" />
<link rel="stylesheet" type="text/css" href="style.css" />
</head>
<body>
<div id="main">
<div id="notice" style="width: 58em; max-width: 100%; margin-left: auto; margin-right: auto; border: 1px solid black; margin-bottom: 2em">
<table>
<tr>
<td style="font-size: 72px; color: firebrick; padding: 0 10px 0 10px">⚠</td>
<td>
<p style="margin: 0.4em">
NOTICE! This is a static HTML version of a legacy ImageJ Trac ticket.
</p>
<p style="margin: 0.4em">
The ImageJ project now
<a href="https://imagej.net/Issues">uses GitHub Issues</a> for issue tracking.
</p>
<p style="margin: 0.4em">
Please
<a href="https://github.com/imagej/imagej/issues/new">file all new issues</a>
there.
</p>
</td>
</tr>
</table>
</div>
<div id="content" class="ticket">
<h1 id="trac-ticket-title">
<a href="1096.html">Ticket #1096</a>
<span class="status">(closed defect: fixed)</span>
</h1>
<div id="ticket">
<div class="date">
<p>Opened 2012-04-10T13:48:11-05:00</p>
<p>Last modified 2012-08-29T13:48:48-05:00</p>
</div>
<h2 class="summary searchable">SaltAndPepper issue</h2>
<table class="properties">
<tr>
<th id="h_reporter">Reported by:</th>
<td headers="h_reporter" class="searchable">
bdezonia
</td>
<th id="h_owner">Owned by:</th>
<td headers="h_owner">
bdezonia
</td>
</tr>
<tr>
<th id="h_priority">
Priority:
</th>
<td headers="h_priority">
major
</td>
<th id="h_milestone">
Milestone:
</th>
<td headers="h_milestone">
<strike>imagej2-b4-plugins</strike>
</td>
</tr><tr>
<th id="h_component">
Component:
</th>
<td headers="h_component">
Plugins
</td>
<th id="h_version">
Version:
</th>
<td headers="h_version">
</td>
</tr><tr>
<th id="h_severity">
Severity:
</th>
<td headers="h_severity">
serious
</td>
<th id="h_keywords">
Keywords:
</th>
<td headers="h_keywords" class="searchable">
</td>
</tr><tr>
<th id="h_cc">
Cc:
</th>
<td headers="h_cc" class="searchable">
</td>
<th id="h_blockedby">
Blocked By:
</th>
<td headers="h_blockedby">
</td>
</tr><tr>
<th id="h_blocking">
Blocking:
</th>
<td headers="h_blocking">
<a class="closed" href="1333.html" title="Add new functionality to showcase IJ2 [plugins]">#1333</a>
</td>
<th>
</th>
<td>
</td>
</tr>
</table>
<div class="description">
<h3 id="comment:description">
Description
</h3>
<div class="searchable">
<p>
The SaltAndPepper plugin fills in pixels with min/max values relative to the type (0/255 for 8-bit, 0/65535 for 16-bit, etc.). This can cause problems.<br />
</p>
<p>
To see a problem try the following:<br />
open T1 Head<br />
run SaltAndPepper<br />
run Noise Reducer plugin<br />
in the plugin use median and 3x3 neighborhood<br />
</p>
<p>
notice after running that everything looks black. But if you move z slider to middle and look at probe you can see there are many nonzero pixel values. Unfortunately there are som 0's and some 65535's and everything else is on a scale that is not visible.<br />
</p>
<p>
We need to determine better values for filling salt and pepper pixels in images that are not 8-bit<br />
</p>
</div>
</div>
</div>
<div>
<h2 class="foldable">Change History</h2>
<div id="changelog">
<div class="change" id="trac-change-1">
<h3 class="change">
<span class="threading">
<span id="comment:1" class="cnum">
<a href="#comment:1">comment:1</a>
</span>
</span>
Changed 2012-05-04T11:14:03-05:00 by bdezonia
</h3>
<div class="comment searchable">
<p>
Alternatively smart display range handling could improve situation<br />
</p>
</div>
</div>
<div class="change" id="trac-change-2">
<h3 class="change">
<span class="threading">
<span id="comment:2" class="cnum">
<a href="#comment:2">comment:2</a>
</span>
</span>
Changed 2012-05-14T11:14:18-05:00 by bdezonia
</h3>
<ul class="changes">
<li>
<strong>Milestone</strong>
changed from <em>imagej-2.0.0-beta3</em> to <em>imagej-2.0.0-beta4</em>
</li>
</ul>
<div class="comment searchable">
</div>
</div>
<div class="change" id="trac-change-3">
<h3 class="change">
<span class="threading">
<span id="comment:3" class="cnum">
<a href="#comment:3">comment:3</a>
</span>
</span>
Changed 2012-07-02T14:27:48-05:00 by bdezonia
</h3>
<div class="comment searchable">
<p>
Plan:<br />
</p>
<ul><li>add parameters for Salt value and Pepper value
</li><li>default them to persisted values (initially 0,255)
</li><li>provide an Auto button that uses the current image's min/max pixel values
</li></ul>
</div>
</div>
<div class="change" id="trac-change-4">
<h3 class="change">
<span class="threading">
<span id="comment:4" class="cnum">
<a href="#comment:4">comment:4</a>
</span>
</span>
Changed 2012-07-17T16:23:52-05:00 by bdezonia
</h3>
<ul class="changes">
<li>
<strong>Blocking</strong>
<em>1333</em> added
</li>
</ul>
<div class="comment searchable">
<p>
The application of S&P to images other than 8=bit is functionality beyond IJ1. Proceed with plan.<br />
</p>
</div>
</div>
<div class="change" id="trac-change-5">
<h3 class="change">
<span class="threading">
<span id="comment:5" class="cnum">
<a href="#comment:5">comment:5</a>
</span>
</span>
Changed 2012-08-27T16:14:52-05:00 by bdezonia
</h3>
<div class="comment searchable">
<p>
With commit d1d0fc8963c11fb0fd14d69f21a702715b8387d6 the specification of salt/pepper values in place.<br />
</p>
<p>
Now just need auto button or checkbox that specifies to use image min/max values<br />
</p>
</div>
</div>
<div class="change" id="trac-change-6">
<h3 class="change">
<span class="threading">
<span id="comment:6" class="cnum">
<a href="#comment:6">comment:6</a>
</span>
</span>
Changed 2012-08-29T13:48:48-05:00 by bdezonia
</h3>
<ul class="changes">
<li>
<strong>Status</strong>
changed from <em>new</em> to <em>closed</em>
</li><li>
<strong>Resolution</strong>
set to <em>fixed</em>
</li>
</ul>
<div class="comment searchable">
<p>
With commit 9371d6d49db8c81bcde91c9bfc233ba2a551b5b3 the user can choose a checkbox that will allow the max and min data values to be used as the salt and pepper values.<br />
</p>
<p>
We could have a nice button that when clicked would compute those values and update the dialog before you hit OK. But that may be overkill and likely waits upon some needed infrastructure. Closing this and opening a new ticket for that functionality in a later milestone.<br />
</p>
</div>
</div>
</div>
</div>
</div>
</div>
</body>
</html>