/
1653.html
326 lines (284 loc) · 11.1 KB
/
1653.html
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<!-- See: http://trac.edgewall.org/wiki/TracInterfaceCustomization -->
<head>
<title>
#1653 (Add BigInteger and BigDecimal numerical types)
– ImageJ
</title>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
<link rel="stylesheet" href="trac.css" type="text/css" /><link rel="stylesheet" href="ticket.css" type="text/css" /><link rel="stylesheet" href="tracvote.css" type="text/css" />
<link rel="stylesheet" type="text/css" href="style.css" />
</head>
<body>
<div id="main">
<div id="notice" style="width: 58em; max-width: 100%; margin-left: auto; margin-right: auto; border: 1px solid black; margin-bottom: 2em">
<table>
<tr>
<td style="font-size: 72px; color: firebrick; padding: 0 10px 0 10px">⚠</td>
<td>
<p style="margin: 0.4em">
NOTICE! This is a static HTML version of a legacy ImageJ Trac ticket.
</p>
<p style="margin: 0.4em">
The ImageJ project now
<a href="https://imagej.net/Issues">uses GitHub Issues</a> for issue tracking.
</p>
<p style="margin: 0.4em">
Please
<a href="https://github.com/imagej/imagej/issues/new">file all new issues</a>
there.
</p>
</td>
</tr>
</table>
</div>
<div id="content" class="ticket">
<h1 id="trac-ticket-title">
<a href="1653.html">Ticket #1653</a>
<span class="status">(closed feature: moved)</span>
</h1>
<div id="ticket">
<div class="date">
<p>Opened 2013-02-21T15:46:44-06:00</p>
<p>Last modified 2013-08-01T13:57:12-05:00</p>
</div>
<h2 class="summary searchable">Add BigInteger and BigDecimal numerical types</h2>
<table class="properties">
<tr>
<th id="h_reporter">Reported by:</th>
<td headers="h_reporter" class="searchable">
curtis
</td>
<th id="h_owner">Owned by:</th>
<td headers="h_owner">
curtis
</td>
</tr>
<tr>
<th id="h_priority">
Priority:
</th>
<td headers="h_priority">
major
</td>
<th id="h_milestone">
Milestone:
</th>
<td headers="h_milestone">
imagej2-b8-analysis
</td>
</tr><tr>
<th id="h_component">
Component:
</th>
<td headers="h_component">
ImgLib2
</td>
<th id="h_version">
Version:
</th>
<td headers="h_version">
</td>
</tr><tr>
<th id="h_severity">
Severity:
</th>
<td headers="h_severity">
non-issue
</td>
<th id="h_keywords">
Keywords:
</th>
<td headers="h_keywords" class="searchable">
</td>
</tr><tr>
<th id="h_cc">
Cc:
</th>
<td headers="h_cc" class="searchable">
</td>
<th id="h_blockedby">
Blocked By:
</th>
<td headers="h_blockedby">
</td>
</tr><tr>
<th id="h_blocking">
Blocking:
</th>
<td headers="h_blocking">
</td>
<th>
</th>
<td>
</td>
</tr>
</table>
<div class="description">
<h3 id="comment:description">
Description
</h3>
<div class="searchable">
<p>
The ImgLib2 library has type-agnostic support for numerical data processing. As such, it would be great to have numerical types based on Java's <tt>BigInteger</tt> and <tt>BigDecimal</tt>, for arbitrary-precision integer- and real-valued numbers, respectively.<br />
</p>
<p>
Implementing this feature will first require the types to exist within ImgLib2. Then we will need to write additional converter plugins (for the Image > Type menu) as well as ensure that ImageJ2's core numerical commands are well-tested with the new types. Right now, many plugins "cheat" by operating on doubles, which would defeat the purpose of the new types.<br />
</p>
</div>
</div>
</div>
<div>
<h2 class="foldable">Change History</h2>
<div id="changelog">
<div class="change" id="trac-change-1">
<h3 class="change">
<span class="threading">
<span id="comment:1" class="cnum">
<a href="#comment:1">comment:1</a>
</span>
</span>
Changed 2013-05-14T14:35:04-05:00 by bdezonia
</h3>
<div class="comment searchable">
<p>
In order to avoid working in doubles we'll also have to provide methods of calculation of basic math functions (like Math.sin(), Math.exp(), Math.log()). This was part of what the types-experiment branch of imglib2 was investigating.<br />
</p>
</div>
</div>
<div class="change" id="trac-change-2">
<h3 class="change">
<span class="threading">
<span id="comment:2" class="cnum">
<a href="#comment:2">comment:2</a>
</span>
</span>
Changed 2013-07-10T12:04:12-05:00 by bdezonia
</h3>
<div class="comment searchable">
<p>
Some work towards this is done on the data-types branch including Image > Type > Change plugin and BigInteger and BigDecimal backed types (in imagej packages not imglib). See also ticket <a class="closed ticket" href="1702.html" title="feature: Make pixel types extensible (closed: fixed)">#1702</a>.<br />
</p>
</div>
<div class="trac-lastedit ">
Last edited 2013-07-10T12:04:54-05:00
by bdezonia
</div>
</div>
<div class="change" id="trac-change-3">
<h3 class="change">
<span class="threading">
<span id="comment:3" class="cnum">
<a href="#comment:3">comment:3</a>
</span>
</span>
Changed 2013-07-12T10:42:40-05:00 by bdezonia
</h3>
<div class="comment searchable">
<p>
The two "big" DataTypes in the data-types branch have a current limitation that makes them unusable by IJ2. IJ2 expects Datasets to support RealType and NativeType. The two types can fake RealType (through narrowing data manipulations of doubles and longs) but they can't fake NativeType. We need to eliminate the NativeType requirement of Dataset.<br />
</p>
</div>
</div>
<div class="change" id="trac-change-4">
<h3 class="change">
<span class="threading">
<span id="comment:4" class="cnum">
<a href="#comment:4">comment:4</a>
</span>
</span>
Changed 2013-07-12T17:13:23-05:00 by bdezonia
</h3>
<div class="comment searchable">
<p>
Also note as part of merging <a class="closed ticket" href="1702.html" title="feature: Make pixel types extensible (closed: fixed)">#1702</a> to master I commented out the @Plugin annotation to the four as yet unsupportable DataTypes (the two complex types and the two unbounded types). When we are ready to support these classes simply reenable the @Plugin annotation in each of these DataTypes and they will be discovered by NewImage and TypeChanger. Of course we need to make changes to IJ2 to allow Datasets of these types to be constructed.<br />
</p>
</div>
</div>
<div class="change" id="trac-change-5">
<h3 class="change">
<span class="threading">
<span id="comment:5" class="cnum">
<a href="#comment:5">comment:5</a>
</span>
</span>
Changed 2013-08-01T10:43:48-05:00 by bdezonia
</h3>
<div class="comment searchable">
<p>
A BigDecimal backed type cannot be implemented in a naive way. Take an BigDecimal and divide by 3. An exception is thrown due to repeating decimal expansion.<br />
</p>
<p>
Our "unlimited" decimal precision class will likely need to be a fixed point representation with some number of decimal places supported (i.e. like 50) rather than BigDecimal backed.<br />
</p>
<p>
This is already true of the implementation for sqrt() and atan2(). And more if we add other floating operations.<br />
</p>
</div>
</div>
<div class="change" id="trac-change-6">
<h3 class="change">
<span class="threading">
<span id="comment:6" class="cnum">
<a href="#comment:6">comment:6</a>
</span>
</span>
Changed 2013-08-01T10:52:20-05:00 by curtis
</h3>
<div class="comment searchable">
<blockquote class="citation">
<p>
Our "unlimited" decimal precision class will likely need to be a fixed point representation<br />
</p>
</blockquote>
<p>
Indeed. Perhaps we can have ImageJ prompt the user for the number of significant digits of precision, when converting to that type. This would be a great feature.<br />
</p>
</div>
</div>
<div class="change" id="trac-change-7">
<h3 class="change">
<span class="threading">
<span id="comment:7" class="cnum">
<a href="#comment:7">comment:7</a>
</span>
</span>
Changed 2013-08-01T13:57:12-05:00 by bdezonia
</h3>
<div class="comment searchable">
<p>
With commit 331ddf635c0bebe61d51bab1859620bb1fe0ef1e we have a basic fixed point class in place for later use. It needs to be extended to support Imglib's FloatingType when that code is merged to master. Number of decimal places is fixed at 25 places but could be extended to be configurable.<br />
</p>
</div>
</div>
<div class="change" id="trac-change-8">
<h3 class="change">
<span class="threading">
<span id="comment:8" class="cnum">
<a href="#comment:8">comment:8</a>
</span>
</span>
Changed 2014-11-25T16:28:23-06:00 by curtis
</h3>
<ul class="changes">
<li>
<strong>Status</strong>
changed from <em>new</em> to <em>closed</em>
</li><li>
<strong>Resolution</strong>
set to <em>moved</em>
</li>
</ul>
<div class="comment searchable">
<p>
Migrated to <a class="ext-link" href="https://github.com/imagej/imagej-common/issues/35"><span class="icon"> </span>https://github.com/imagej/imagej-common/issues/35</a><br />
</p>
</div>
</div>
</div>
</div>
</div>
</div>
</body>
</html>