/
1833.html
179 lines (165 loc) · 5.78 KB
/
1833.html
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<!-- See: http://trac.edgewall.org/wiki/TracInterfaceCustomization -->
<head>
<title>
#1833 (Drag and Drop: support .xls and .csv files)
– ImageJ
</title>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
<link rel="stylesheet" href="trac.css" type="text/css" /><link rel="stylesheet" href="ticket.css" type="text/css" /><link rel="stylesheet" href="tracvote.css" type="text/css" />
<link rel="stylesheet" type="text/css" href="style.css" />
</head>
<body>
<div id="main">
<div id="notice" style="width: 58em; max-width: 100%; margin-left: auto; margin-right: auto; border: 1px solid black; margin-bottom: 2em">
<table>
<tr>
<td style="font-size: 72px; color: firebrick; padding: 0 10px 0 10px">⚠</td>
<td>
<p style="margin: 0.4em">
NOTICE! This is a static HTML version of a legacy ImageJ Trac ticket.
</p>
<p style="margin: 0.4em">
The ImageJ project now
<a href="https://imagej.net/Issues">uses GitHub Issues</a> for issue tracking.
</p>
<p style="margin: 0.4em">
Please
<a href="https://github.com/imagej/imagej/issues/new">file all new issues</a>
there.
</p>
</td>
</tr>
</table>
</div>
<div id="content" class="ticket">
<h1 id="trac-ticket-title">
<a href="1833.html">Ticket #1833</a>
<span class="status">(new defect)</span>
</h1>
<div id="ticket">
<div class="date">
<p>Opened 2013-04-18T17:11:13-05:00</p>
<p>Last modified 2013-04-18T23:29:11-05:00</p>
</div>
<h2 class="summary searchable">Drag and Drop: support .xls and .csv files</h2>
<table class="properties">
<tr>
<th id="h_reporter">Reported by:</th>
<td headers="h_reporter" class="searchable">
bdezonia
</td>
<th id="h_owner">Owned by:</th>
<td headers="h_owner">
curtis
</td>
</tr>
<tr>
<th id="h_priority">
Priority:
</th>
<td headers="h_priority">
major
</td>
<th id="h_milestone">
Milestone:
</th>
<td headers="h_milestone">
imagej2-b10-compatibility
</td>
</tr><tr>
<th id="h_component">
Component:
</th>
<td headers="h_component">
Core
</td>
<th id="h_version">
Version:
</th>
<td headers="h_version">
</td>
</tr><tr>
<th id="h_severity">
Severity:
</th>
<td headers="h_severity">
serious
</td>
<th id="h_keywords">
Keywords:
</th>
<td headers="h_keywords" class="searchable">
</td>
</tr><tr>
<th id="h_cc">
Cc:
</th>
<td headers="h_cc" class="searchable">
</td>
<th id="h_blockedby">
Blocked By:
</th>
<td headers="h_blockedby">
</td>
</tr><tr>
<th id="h_blocking">
Blocking:
</th>
<td headers="h_blocking">
<a class="new" href="1821.html" title="Improve drag-and-drop [compatibility]">#1821</a>
</td>
<th>
</th>
<td>
</td>
</tr>
</table>
<div class="description">
<h3 id="comment:description">
Description
</h3>
<div class="searchable">
<p>
In IJ1 dragged and dropped .xls and .csv files open as results tables. Make this work in IJ2. (I believe it was before a recent refactor was done).<br />
</p>
</div>
</div>
</div>
<div>
<h2 class="foldable">Change History</h2>
<div id="changelog">
<div class="change" id="trac-change-1">
<h3 class="change">
<span class="threading">
<span id="comment:1" class="cnum">
<a href="#comment:1">comment:1</a>
</span>
</span>
Changed 2013-04-18T23:29:11-05:00 by curtis
</h3>
<div class="comment searchable">
<p>
I did not see any support for .xls or .csv files while working on the drag-and-drop branch (apologies if I missed it somehow).<br />
</p>
<p>
The closest thing I can think of is that in <a class="missing changeset" title="No default repository defined">bfd6e895</a> the LUT service's API was refactored. As part of that change, the logic which could decode a ColorTable from a text LUT was disabled, due to the fact that the TableLoader class only operates on URLs.<br />
</p>
<p>
However, I am not certain any of that is relevant to results tables.<br />
</p>
<p>
It looks like nothing uses the <tt>TableLoader</tt> now. But it is certainly what <em>would</em> be used to support .xls and .csv...<br />
</p>
<p>
In a <a class="ext-link" href="http://imagej.net/pipermail/imagej-devel/2013-April/001472.html"><span class="icon"> </span>recent thread to imagej-devel</a> I inquired whether we should really be doing all this stuff for drag-and-drop specifically, rather than as I/O handler plugins for use with the new <tt>IOService#load(File)</tt> method. In line with that, I propose that a new <tt>IOHandler</tt> be created which uses the <tt>TableLoader</tt> to create a <tt>ResultsTable</tt> from the data. A generic <tt>FileDragAndDropHandler</tt> which uses <tt>IOService#load(File)</tt> will take care of the rest, and this ticket is solved!<br />
</p>
</div>
</div>
</div>
</div>
</div>
</div>
</body>
</html>