Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image not optimizing #42

Closed
asafigan opened this issue Oct 2, 2017 · 6 comments
Closed

Image not optimizing #42

asafigan opened this issue Oct 2, 2017 · 6 comments

Comments

@asafigan
Copy link

asafigan commented Oct 2, 2017

I have an image that is not optimizing. I tried using pngquant directly and it optimized the image no problem.
thumb_1501621736

@asafigan
Copy link
Author

asafigan commented Oct 2, 2017

Found the issue. Your code is not throwing the 99 error. Can there be a better explanation on what the quality option does? I don't understand completely. Is it an important option or should I not use it?

@asafigan
Copy link
Author

asafigan commented Oct 2, 2017

Reading the readme more closely, I think this option adds an additional optimization, but checks the quality of that optimization. Is this true?

@kevva
Copy link
Member

kevva commented Oct 3, 2017

What options did you run it with? When optimizing it on macOS I get an 20 KB image as opposed to 170 KB which the source image is.

@asafigan
Copy link
Author

asafigan commented Oct 4, 2017

the problem was that I added quality '70-80'. I didn't really know what quality did at the time. I decided to leave the option out and it works fine. Would still like a better explanation of this option

@kevva
Copy link
Member

kevva commented Oct 6, 2017

The quality option is a "threshold", sort of. You define a range in which the image can't be under the minimum. Maybe 70-100 would've worked better, or even lowering the minimum a bit.

@kevva kevva closed this as completed Oct 6, 2017
@asafigan
Copy link
Author

asafigan commented Oct 6, 2017

I left this out because it seems to add another level of optimization that isn't needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants