Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove vinyl dependencies #100

Closed
kevva opened this issue May 23, 2015 · 3 comments
Closed

Remove vinyl dependencies #100

kevva opened this issue May 23, 2015 · 3 comments

Comments

@kevva
Copy link
Member

kevva commented May 23, 2015

Should just use regular buffers/streams instead to simplify things. This would probably have a positive impact on #97 too.
@shinnn
Copy link
Contributor

shinnn commented May 25, 2015

to simplify things

Hmm, vinyl-based code seems enough simple for me. I'm afraid that removing vinyl dependencies would just brings another complexity.

@kevva
Copy link
Member Author

kevva commented May 25, 2015

Hm, lets wait and see. I've started to remove vinyl dependencies from decompress and which removes a lot of complexity imo, https://github.com/kevva/decompress-tar/blob/remove-vinyl/index.js.

@kevva
Copy link
Member Author

kevva commented Apr 29, 2016

Fixed in ff8b4e6.

@kevva kevva closed this as completed Apr 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevva @shinnn