Skip to content

Commit

Permalink
NPM refuses to include the file when named rebuild-*
Browse files Browse the repository at this point in the history
  • Loading branch information
sindresorhus committed Feb 22, 2013
1 parent d89fff7 commit 8d8707b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
File renamed without changes.
4 changes: 2 additions & 2 deletions package.json
Expand Up @@ -24,8 +24,8 @@
"url": "git://github.com/yeoman/node-optipng-bin.git"
},
"scripts": {
"test": "node node_modules/mocha/bin/mocha test/test-*.js",
"postinstall": "node rebuild-optipng.js"
"test": "mocha test/test-*.js",
"postinstall": "node build.js"
},
"engines": {
"node": ">=0.8.0"
Expand Down

6 comments on commit 8d8707b

@anacronw
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an npm bug?

@sindresorhus
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be, at least it wasn't clear at all it would happen, so if it's not a bug, it's a documentation issue. After some debugging I realized the rebuild-optipng.js file wasn't included in the npm package at all. You mind opening a ticket on npm?

@anacronw
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but I want to reproduce first so I understand it better - this occurs on npm publish?

@sindresorhus
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, (or on npm install, dunno).

@anacronw
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't reproduce the problem - I checked out the commit before this change, change the version/package name and tried publishing. I then installed successfully with npm install.

@sindresorhus
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it apparently work when the force publish over the new version a second time. I've had this problem with other packages of mine too. Weird :/

Please sign in to comment.