Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
NPM refuses to include the file when named
rebuild-*
- Loading branch information
1 parent
d89fff7
commit 8d8707b
Showing
2 changed files
with
2 additions
and
2 deletions.
There are no files selected for viewing
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8d8707b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an npm bug?
8d8707b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be, at least it wasn't clear at all it would happen, so if it's not a bug, it's a documentation issue. After some debugging I realized the rebuild-optipng.js file wasn't included in the npm package at all. You mind opening a ticket on npm?
8d8707b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, but I want to reproduce first so I understand it better - this occurs on npm publish?
8d8707b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, (or on
npm install
, dunno).8d8707b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't reproduce the problem - I checked out the commit before this change, change the version/package name and tried publishing. I then installed successfully with
npm install
.8d8707b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it apparently work when the force publish over the new version a second time. I've had this problem with other packages of mine too. Weird :/