Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window Resize doesn't trigger refresh when waypoint has a context other than window #442

Closed
johngrogg opened this issue Aug 21, 2015 · 3 comments

Comments

@johngrogg
Copy link

This is due to the fact that the resize event only fires for the window element. Context.prototype.createThrottledResizeHandler needs to have the 'resize.waypoints' event binding always be bound to the window element, regardless of context.

@shellscape
Copy link

@imakewebthings ping. please do have a look at this one. we're suffering from the same problem.

@imakewebthings
Copy link
Owner

@johngrogg Agreed this needs to be changed, but not exactly in the way proposed in the PR. Rather than bind create a windowAdapter for each context, each with its own resizeHandler, we can create one window adapter and throttle a call to Waypoint.refreshAll(). I believe Waypoints did this in the 2.x days and I can't for the life of me remember a reason why I would have removed it, except for forgetfulness.

@imakewebthings
Copy link
Owner

Fixed in the 4.0.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants