-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
target image file name is fixed to "page-" #13
Comments
Hi, Thank you for this great conversion utility. I just like to ask if it is possible to pass a "target file name for the converted images" maybe in the next version? example:
Thanks in advance |
@mablae @ahfeel @joshbmarshall guys can you please see this something we should implement ? |
it would be a nice enhancement. However it needs to be done in a BC secure way or implies new major Version with this approach. (New param would break BC) Instead introducing an new parameter on convert method it could be done with a new setter method It also needs to be checked to contain page parameter and then use Let me know what you think. |
You'd definitely do it in the way you currently set resolution - by adding as a setter method. So the default would be page- and the function would let you override. No BC issues then as @mablae suggested. That should be fairly straightforward to implement and use. Going on conventions of other software I doubt we need to have the page number configurable in the image file name. Do you want a pull request? |
I think I agree with @mablae too, it is the way to go! @joshbmarshall please go ahead if you have time |
pull request has been submitted #14 |
Can anyone review @joshbmarshall 's code and merge it and create tag for release version 1.2.2, if all are busy I'll have a look at this tonight and probably merge it.. please make sure Tests are passing |
I just added to the pull request, some PHPDoc and add method chaining to allow end users have cleaner code. |
@joshbmarshall thanks for the great work!!! |
@imalhasaranga there is one test not passing on the current master with Ghostscript v9.26 on linux - PDFLibTest::testImageToPdf |
hmm! we should find the root case and fix it, I mean tests are the only way we know that nothing has broken.. probably this may be an issue existed from the begining and no one noticed it |
sorry release should be v1.2.3 |
I have found the issue with the gs on linux, putting in a fix now will add to the pull request |
Done, please check tests pass on windows. They all pass on Alpine Linux with PHP7.3.2 |
Thank you for adding this feature. I really needed this. Thanks again and more power to you guys who made this amazing conversion utility. |
Since this is a new feature I would release as v1.3.0 |
@vtsoft v1.3.0 is released, @mablae agreed!! @joshbmarshall awesome work mate!!! cheers |
@imalhasaranga, @mablae, @joshbmarshall, Guys, Thanks for the quick release of the new version. It's really a great help. If not too much to ask, Thanks again and more power to you guys. |
@vtsoft I have not used CentOS 6 for over 4 years. Even CentOS 7 has too old a version. You just need gs version 9.16 or newer. I tested with v9.26. Maybe you can use the GPL linux binaries from https://ghostscript.com/download/gsdnld.html |
@joshbmarshall Thank you for your help. and Thanks again all of you guys. |
No description provided.
The text was updated successfully, but these errors were encountered: