Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to pass custom LineChartPainter #32

Closed
Mazas17 opened this issue Jul 6, 2019 · 6 comments
Closed

Allow to pass custom LineChartPainter #32

Mazas17 opened this issue Jul 6, 2019 · 6 comments
Labels
enhancement New feature or request

Comments

@Mazas17
Copy link

Mazas17 commented Jul 6, 2019

Could you add possibility to pass custom LineChartPainter to LineChart? I would like to paint some additional data on line point click.
@imaNNeo
Copy link
Owner

imaNNeo commented Jul 6, 2019

what kind of additional data would you paint?

@Mazas17
Copy link
Author

Mazas17 commented Jul 6, 2019

I would like to add some additional text. In any case, this shouldn't matter, because I would just override paint method and repaint whatever I need.

@imaNNeo
Copy link
Owner

imaNNeo commented Jul 6, 2019

Ok let me investigate on it, I will back you soon

@imaNNeo imaNNeo added the enhancement New feature or request label Jul 6, 2019
@imaNNeo
Copy link
Owner

imaNNeo commented Jul 10, 2019

Hi, currently we can't have a CustomPainter, because it will add non-valuable complexity,
and for now, we have a long path, this is not critical for now, and it needs lots of effort.
but maybe in the future, we have something like this.
Thanks! cheers!

@imaNNeo imaNNeo closed this as completed Jul 10, 2019
@BaronTryBest BaronTryBest mentioned this issue Nov 17, 2021
Closed
@shababhsiddique shababhsiddique mentioned this issue Nov 28, 2021
Closed
@darkang3lz92 darkang3lz92 mentioned this issue Jan 5, 2022
Open
@goatandsheep
Copy link

Hi @imaNNeoFighT are you open to PRs on this ticket?

@imaNNeo
Copy link
Owner

imaNNeo commented Feb 2, 2022

Hi @goatandsheep
PRs are always welcome!
Please let me know what you're gonna do before you start

@nastaran-mohammadi nastaran-mohammadi mentioned this issue May 13, 2022
Closed
@sk784 sk784 mentioned this issue Jun 9, 2022
Closed
@xuenuanxi xuenuanxi mentioned this issue Jun 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@goatandsheep @imaNNeo @Mazas17