Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing minor bug in chat stream output - python error being serialized #1449

Merged
merged 1 commit into from Jan 16, 2024

Conversation

roblg
Copy link
Contributor

@roblg roblg commented Dec 22, 2023

This is a proposed fix for a minor bug I noticed while using simonw/llm to connect to a local privategpt instance -- I'm seeing serialized python error strings in the output. I'm not entirely sure why this shows up in this tool, but not via the UI, but it might have to do with how the output is parsed or something.

Behavior I was seeing:

Containers, in the context of computing and software development, are lightweight, standalone, executable software packages that include everything needed to run a piece of software: code, runtime, system tools, system libraries, and 

<... snip additional output...>

Containers have become a key component in modern software development and deployment practices, particularly in the context of microservices architectures, where applications are built as a collection of loosely coupled services.Error: can only concatenate str (not "NoneType") to str

The Error: can only concatenate str (not "NoneType") to str seems to be coming from the server-side. There might be a better way to fix this, but this seemed to work (and aligns w/ my expectations of a fix for NoneType being concatenated w/ str).

Copy link
Collaborator

@imartinez imartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link
Contributor

Stale pull request

@github-actions github-actions bot added the stale label Jan 11, 2024
@imartinez imartinez merged commit 6191bcd into zylon-ai:main Jan 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants