Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fat jar all the thing ? #149

Closed
ImFlog opened this issue Nov 6, 2023 · 1 comment
Closed

Fat jar all the thing ? #149

ImFlog opened this issue Nov 6, 2023 · 1 comment

Comments

@ImFlog
Copy link
Owner

ImFlog commented Nov 6, 2023

While tinkering on the project I wondered if we could get rid of the buildscript repositories dependencies. Turns out it's possible by using a fat jar.
I did it for the Avro custom plugin (didn't really wanted to expose it in the first place) but left the Confluent plugin out of the jar for now.

I think we could embed it as the new features on the schema registry are not many but I am not sure about the plugin usage.

If no-one disagree with this, I will put the confluent libs in the fat jar and thus provide a better integration experience (just apply the plugin).

NB: One way to mitigate that would be to use the confluent version as my plugin version, this can cause issue if I add features that are not related to confluent in itself.

@ImFlog
Copy link
Owner Author

ImFlog commented Nov 6, 2023

Changed my mind, will do it for confluent packages too.

@ImFlog ImFlog closed this as completed Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant