-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to toggle pretty-print of outputted schema files for Avro/JSON formats #158
Comments
As a suggested solution, the best way that I can see to support this would be to add an optional |
Hello @filpano, We can check later for protobuf (not using it either). I'll be glad to assist you on this PR, feel free to start tinkering and push something even if not finished (with the allow edits from maintainer) so I can step up to help when you need ;) |
Thanks for the quick reply. I had a much deeper look at that whole thread than I would've liked to :) but it doesn't seem like that'll work for this use case:
So I think either the schema registry needs support for What do you think? |
I think we should add support on our side for now while opening an issue on the confluent repository (and linking to this issue). |
…AVRO and JSON schemas
Signed-off-by: Filip Panovski <fil.panovski@gmail.com>
Signed-off-by: Filip Panovski <fil.panovski@gmail.com>
Signed-off-by: Filip Panovski <fil.panovski@gmail.com>
# Conflicts: # src/main/kotlin/com/github/imflog/schema/registry/tasks/download/DownloadTaskAction.kt # src/test/kotlin/com/github/imflog/schema/registry/tasks/download/DownloadTaskActionTest.kt
…nd JSON schemas (#160) Signed-off-by: Filip Panovski <fil.panovski@gmail.com>
I have a small issue with the plugin publishing (an error on Gradle side it seems) but I didn't forget to release this. |
It's been released in https://github.com/ImFlog/schema-registry-plugin/releases/tag/v1.13.0 |
Currently, all downloaded schemas are saved "as-received" from the Schema Registry, i.e. one-line with a single terminating newline character.
Since generated files have tons of serde fields, their readability is not that great. It would be nice if there was a toggle to save the schema information as formatted JSON for the relevant schema types (
avro
,json
).In addition, if we want to check in the files to VCS, e.g. Git would always overwrite the files if we were to format them manually and check them in, which is not ideal.
@ImFlog If you also think that something like this is in the spirit of the plugin, I could take a stab at a PR. IMO, it improves my workflow significantly (download schemas, generate, check-in to track schema changes in Git).
The text was updated successfully, but these errors were encountered: