Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand Gif Image files support #644

Closed
Davoleo opened this issue Apr 25, 2020 · 6 comments
Closed

expand Gif Image files support #644

Davoleo opened this issue Apr 25, 2020 · 6 comments

Comments

@Davoleo
Copy link

Davoleo commented Apr 25, 2020

Gifs usually take up a lot of space, it'd be nice if img-bot could do some optimizations to reduce their file size

Possible reference: #332

@dabutvin dabutvin changed the title Gif Image files support expand Gif Image files support May 2, 2020
@dabutvin
Copy link
Contributor

dabutvin commented May 2, 2020

we do optimize gifs today using Image Magick gif optimizer https://github.com/dlemstra/Magick.NET/blob/master/src/Magick.NET/Shared/Optimizers/GifOptimizer.cs

I could however see us implementing something additional like gifsicle to do even more
https://packages.debian.org/unstable/graphics/gifsicle

@Davoleo
Copy link
Author

Davoleo commented May 2, 2020

umh, then I wonder why it didn't try to optimize gifs in this PR: Davoleo/davoleo.github.io#5 🤔
is it disabled by default?
for instance this one: https://github.com/Davoleo/davoleo.github.io/blob/master/res/img/pp/demon_slayer.gif

@dabutvin
Copy link
Contributor

Hi @Davoleo
Gif optimization is enabled by default.
I just took a look at the logs for that compression run and it did try to optimize that gif, but found no space savings. I'm going to try again with gifsicle and see if that can do anything further

@dabutvin
Copy link
Contributor

added support for gifsicle in #654

@Davoleo I forked your example project to try it out on.

This is with the default settings: dabutvin/davoleo.github.io#1

This is with the opt in to aggressive compresion: dabutvin/davoleo.github.io#2

@Davoleo
Copy link
Author

Davoleo commented May 10, 2020

oh I see, thanks for the help

@dabutvin
Copy link
Contributor

released in 1.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants