Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update closure file test to include more src files #78

Merged
merged 1 commit into from Aug 8, 2018

Conversation

frederickfogerty
Copy link
Contributor

@frederickfogerty frederickfogerty commented Aug 7, 2018

Description

This PR updates the webpack and closure config to ensure that all src files are included. The closure plugin we use has a test flag that didn't work initially as I thought, so after investigating this I was able to fix it. As a side-effect of this update, the bundle size is even smaller at 10KB, an improvement of 46% over the original bundle size.

This fixes #75

Bug Fix

  • All existing unit tests are still passing (if applicable)
  • [N/A] Add new passing unit tests to cover the code introduced by your PR
  • [N/A] Update the readme
  • [N/A] Update or add any necessary API documentation
  • Add some steps so we can test your bug fix
  • The PR title is in the conventional commit format: e.g. fix(<area>): fixed bug #issue-number
  • Add your info to the contributors array in package.json!

Steps to Test

IE 11
image

Steps:

  1. Check that CI passes

@frederickfogerty frederickfogerty merged commit 0a1aeca into master Aug 8, 2018
@frederickfogerty frederickfogerty deleted the fred/update-closure-test branch August 8, 2018 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IE 11 Compatibility Bug
2 participants