Add domain validation during ImgixClient initialization #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherwinski
force-pushed
the
domain-validation
branch
2 times, most recently
from
6944323
to
d400994
Compare
jayeb
suggested changes
Mar 7, 2019
sherwinski
force-pushed
the
domain-validation
branch
from
d400994
to
cfd65b0
Compare
|
🎉 This PR is included in version 0.3.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a validation that will throw an error if a user attempts to initialize a new
ImgixClientobject with an invalid domain.The validation criteria is based off of the same regex used on dashboard.imgix.com