Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression in version 1.2 #28

Closed
aronj opened this issue Feb 1, 2018 · 1 comment · Fixed by #31
Closed

Regression in version 1.2 #28

aronj opened this issue Feb 1, 2018 · 1 comment · Fixed by #31

Comments

@aronj
Copy link

aronj commented Feb 1, 2018

A bug slipped through the tests in to the release. From a quick glance I think it is about empty paths.

Uninitialized string offset: 0 in imgix/imgix-php/src/Imgix/UrlHelper.php at 25
@jayeb jayeb mentioned this issue Feb 1, 2018
Merged
@jayeb
Copy link
Contributor

jayeb commented Feb 2, 2018

Closed by #29.

@jayeb jayeb closed this as completed Feb 2, 2018
@jayeb jayeb mentioned this issue Mar 2, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix path encoding imgix/imgix-php
2 participants
@aronj @jayeb