Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API options not supported, some error out #26

Closed
ozzyogkush opened this issue Nov 28, 2016 · 2 comments
Closed

API options not supported, some error out #26

ozzyogkush opened this issue Nov 28, 2016 · 2 comments

Comments

@ozzyogkush
Copy link

ozzyogkush commented Nov 28, 2016

Background: I am attempting to evaluate Imgix for use in websites my company runs, using jekyll/imgix 1.1.0 (which uses the same version of this repo).

When trying to use options such as crop or fit, it simply omits the value specified in the tag. EG:

{{ image_filename | imgix_url: w: 480, crop: faces }}

results in a string omitting that value (in this case, faces): myfile.jpg?w=480&crop=

I'm not sure if this belongs here or in the imgix/jekyll-imgix repo's issues, but also using max-w or max-h eg {{ image_filename | imgix_url: w: 480, max-h: 100 }} results in a liquid exception: wrong number of arguments.

@paulstraw
Copy link
Contributor

paulstraw commented Nov 28, 2016

Hey @ozzyogkush, string values such as faces need to be in quotes, e.g., {{ image_filename | imgix_url: w: 480, crop: 'faces' }}.

I've opened imgix/jekyll-imgix#8 to track the issue with dashed params.

@ozzyogkush
Copy link
Author

Ah yeah sorry I was apparently using a symbol, not a string, as the value. My bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants