Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(validation): adds domain validation to client #42

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(validation): adds domain validation to client #42

wants to merge 2 commits into from

Conversation

atlawrie
Copy link
Contributor

@atlawrie atlawrie commented Oct 20, 2022 •
edited

Adds domain validation to library.

Breaking Change

ImgixClient domains are now validated; must be passed in as a fully qualified domain name and without a protocol or path element.

@atlawrie
feat(validation): adds domain validation to client
9a0dd92 
BREAKING CHANGE: ImgixClient domains are now validated; must be passed in as a fully qualified domain name and without a protocol or path element
@atlawrie atlawrie self-assigned this Oct 20, 2022
@commit-lint
Copy link

commit-lint bot commented Oct 20, 2022 •
edited

Features

  • validation: adds domain validation to client (9a0dd92)

Chore

  • constants: rolled constants into client (fcd8a57)

Contributors

atlawrie

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@atlawrie atlawrie marked this pull request as ready for review October 20, 2022 17:29
@atlawrie atlawrie requested a review from a team as a code owner October 20, 2022 17:29
sherwinski
sherwinski approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@sherwinski sherwinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

From offline: we're going to hold off on releasing this for a bit to give us a chance to package other potential breaking changes together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherwinski sherwinski sherwinski approved these changes

Assignees

@atlawrie atlawrie

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@atlawrie @sherwinski @luqven