Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest @imgix/js-core does not work with Nuxt 3 #348

Closed
oliver-heeger opened this issue Dec 23, 2022 · 4 comments · Fixed by #349
Closed

Latest @imgix/js-core does not work with Nuxt 3 #348

oliver-heeger opened this issue Dec 23, 2022 · 4 comments · Fixed by #349
Assignees
Labels
bug dependencies Pull requests that update a dependency file released

Comments

@oliver-heeger
Copy link

@imgix/js-core does not work with latest stable Nuxt 3 version, as it uses an outdated version of ufo.
Multiple major versions of package ufo are being externalized. Picking latest version:
++ /home/projects/nuxt-starter-zucthe/node_modules/ufo@1.0.1
-- /home/projects/nuxt-starter-zucthe/node_modules/@imgix/js-core/node_modules/ufo@0.8.6

To Reproduce
https://stackblitz.com/edit/nuxt-starter-zucthe

Steps to reproduce the behaviour:

  1. Go to https://stackblitz.com/edit/nuxt-starter-zucthe
  2. See error in console

Expected behaviour
@imgix/js-core should not conflict with newer ufo versions.

Information:

  • @imgix/js-core version: 3.7.0
  • Node.js version: 16.14.2
@luqven
Copy link
Contributor

luqven commented Dec 23, 2022

Hey @oliver-heeger,

Thanks for opening this issue and drawing our attention to this. Dependabot stopped nagging us to update this dependency a few weeks back 🤦🏼 .

I've opened a PR to update ufo. Once someone has had a chance to review the PR, we can get this fix shipped.

@luqven luqven self-assigned this Dec 23, 2022
@luqven luqven added bug dependencies Pull requests that update a dependency file labels Dec 23, 2022
@imgix-git-robot
Copy link
Collaborator

🎉 This issue has been resolved in version 3.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@luqven
Copy link
Contributor

luqven commented Dec 23, 2022

Hey @oliver-heeger, js-ore v3.7.1 should have this fixed.

Should anything else come up, please don't hesitate to re-open this issue.

@oliver-heeger
Copy link
Author

@luqven thanks, everything is fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dependencies Pull requests that update a dependency file released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants