feat: add close button #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayeb
suggested changes
Oct 9, 2018
src/js/Lightbox.js
Outdated
| if (e && typeof e.preventDefault === "function") { | ||
| e.preventDefault(); | ||
| } | ||
| if (this.settings.onClose) { |
There was a problem hiding this comment.
We should probably check that this.settings.onClose is actually a function before blindly calling it.
…into fred/close-button * 'fred/close-button' of https://github.com/imgix/luminous: Sync with Prettier
|
@jayeb all changed, can you approve? |
jayeb
approved these changes
Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a close button at the top-right of the screen. A close button seemed like a standard feature that this library should support. The close button can be disabled with
showCloseButton: falsein the configuration object.This PR fixes #72
New Feature
feat(<area>): added new way to do this cool thing #issue-numberSteps to Test
Review the changes to the tests.