Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package cleanup #16

Merged
merged 14 commits into from Jun 7, 2022
Merged

Package cleanup #16

merged 14 commits into from Jun 7, 2022

Conversation

gselzer
Copy link
Contributor

@gselzer gselzer commented Apr 13, 2022

Goals of this PR:

  • Refactor imglyb/ directory into src/imglyb/ directory. See this article for the benefits
  • Minimize setup.py in favor of setup.cfg. This seems to be the preferred approach nowadays.
  • Add a linting strategy (using black)
  • Add a code coverage strategy
  • Allow these features to block merge through Github Actions

Closes #15

@gselzer gselzer force-pushed the package-cleanup branch 28 times, most recently from 5d35aae to 1aba701 Compare April 18, 2022 15:09
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@66d4968). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #16   +/-   ##
=========================================
  Coverage          ?   78.32%           
=========================================
  Files             ?       12           
  Lines             ?      646           
  Branches          ?        0           
=========================================
  Hits              ?      506           
  Misses            ?      140           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66d4968...0652670. Read the comment docs.

@gselzer gselzer force-pushed the package-cleanup branch 5 times, most recently from 3ee1c70 to 5eae989 Compare April 18, 2022 19:18
@gselzer gselzer marked this pull request as ready for review April 18, 2022 19:21
@gselzer
Copy link
Contributor Author

gselzer commented Apr 18, 2022

One thing I think would be slick is exporting these actions to a separate repo. There is a lot of overlap with scyjava, pyimagej.

We may be able to follow the outline presented in number 2 here

@gselzer gselzer force-pushed the package-cleanup branch 3 times, most recently from 84aed4d to 2ec46aa Compare April 18, 2022 20:57
@gselzer gselzer force-pushed the package-cleanup branch 2 times, most recently from af5c554 to 61a4064 Compare June 7, 2022 18:37
@ctrueden ctrueden merged commit fe3b93a into master Jun 7, 2022
@ctrueden ctrueden deleted the package-cleanup branch June 7, 2022 19:06
@ctrueden
Copy link
Member

ctrueden commented Jun 7, 2022

Woot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align Package Structure with PyPA Recommendations
3 participants