Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling winit versions/semver breaking changes #412

Closed
aclysma opened this issue Dec 24, 2020 · 3 comments
Closed

Handling winit versions/semver breaking changes #412

aclysma opened this issue Dec 24, 2020 · 3 comments

Comments

@aclysma
Copy link
Contributor

aclysma commented Dec 24, 2020

I recently had one of my crates break due to a change in the winit-23 feature flag behavior:

  • imgui_winit_support 0.6.0 will use winit 0.23 when using winit-23 feature flag
  • imgui_winit_support 0.6.1 will use winit 0.24 when using winit-23 feature flag

Winit is being used in the public API, so I think this is technically a semver-breaking change. Would keeping the winit feature flags tied to an exact semver version of winit would be a way to avoid this? Bumping imgui_winit_support to 0.7.0 rather than 0.6.1 might have worked too.

I definitely understand juggling winit versions is not fun, and unfortunately I haven't found a better solution that using feature flags!

@thomcc
Copy link
Member

thomcc commented Dec 24, 2020

Ugh, what an awful situation. I had hoped it would be constrained by what other dependencies are needed. It's likely that all the version range-based stuff we do in the winit-support crate is similarly invalid then.

I won't be able to fix this until after the new year, unfortunately.

@aclysma
Copy link
Contributor Author

aclysma commented Dec 24, 2020

Yeah, I was hoping for that behavior too. In one of my other crates I went the route of feature flags for every winit semver version (based on this crate as an example actually). Thanks for looking, hope you have a nice break! :)

@dbr
Copy link
Contributor

dbr commented Jan 17, 2022

Closing; I think this was as solved as can be by #420

@dbr dbr closed this as completed Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants