Skip to content
This repository has been archived by the owner on Aug 1, 2022. It is now read-only.

Upgrade Swift and iOS Deployment Target #10

Merged
merged 11 commits into from Oct 14, 2020
Merged

Upgrade Swift and iOS Deployment Target #10

merged 11 commits into from Oct 14, 2020

Conversation

antazoey
Copy link
Contributor

@antazoey antazoey commented Oct 14, 2020 •
edited

  • Upgrades to Swift 5
  • Fixes build I had with images
  • Upgrades iOS deployment target to 13.7
  • Cleans up some code by removing extra spaces
  • Uses else if in place of if where it makes sense.
  • Add a .gitignore and removes user-specific files from code

jogendra
jogendra suggested changes Oct 14, 2020
View reviewed changes
Copy link
Owner

@jogendra jogendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change

.gitignore Outdated
*.xcuserstate
**/xcuserdata/

PatchDay.xcodeproj/project.xcworkspace/xcuserdata
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this as it is not relevant to this project. I think **/xcuserdata/ will take care of this case.

@jogendra jogendra merged commit 134db57 into jogendra:master Oct 14, 2020
@jogendra
Copy link
Owner

Thanks for your contribution @unparalleled-js ✨

@antazoey antazoey deleted the code-cleanups branch October 14, 2020 18:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jogendra jogendra jogendra approved these changes

Assignees
No one assigned
Labels
Hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@antazoey @jogendra