Migrate to Swift 4 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@NSMyself Please keep swift 4 version in different folder. Create a new folder name technex-ios_swift_4 and put all the code of swift 4 version in this. thanks :) |
|
I don't think folders are the way to go, honestly. May I suggest creating a branch? |
|
@NSMyself yes please go for creating new branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated your code to Swift 4, silenced a couple of errors here and there and also updated the project settings following Xcode 9's suggestion.
The pods still need to be updated though, but that is something that the Pods maintainers have to do, of course.