Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect warning about name collisions #132

Closed
dhilgarth opened this issue Apr 28, 2024 · 5 comments
Closed

Incorrect warning about name collisions #132

dhilgarth opened this issue Apr 28, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@dhilgarth
Copy link

In my StackNetwork.ts, I have this code:

interface Options {
    stackName: string;
    config: NetworkConfig;
}
export { Options as StackNetworkOptions };

In my StackService.ts, I have this code:

interface Options {
    stackName: string;
    config: ServiceConfig;
}

export { Options as StackServiceOptions };

But I still get these warnings:

   WARN     StackNetwork.ts:6:1
   > P:/modular/infrastructure-services/src/constructs/docker-stack/StackNetwork.ts:6:1
   > detect same name of export statement: "Options"

   WARN     StackService.ts:7:1
   > P:/modular/infrastructure-services/src/constructs/docker-stack/StackService.ts:7:1
   > detect same name of export statement: "Options"

@imjuni
Copy link
Owner

imjuni commented May 1, 2024

Thank you for your report. I suspect this is caused by the symbol table not recognising aliases. You can either fix it yourself and send me a PR, or you can give me some time(I've been busy with work recently, so this may take a while) to fix it. Thank you.

@imjuni imjuni self-assigned this May 1, 2024
@imjuni imjuni added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels May 1, 2024
@dhilgarth
Copy link
Author

Unfortunately, I can't provide a PR at this time.

@imjuni
Copy link
Owner

imjuni commented May 21, 2024

@dhilgarth I'm busy with other things right now, so it'll be a while before I can fix this, thank you.

@dhilgarth
Copy link
Author

Sure, don't worry!

@imjuni
Copy link
Owner

imjuni commented Jun 2, 2024

@dhilgarth This issue was fixed in v2.4.5, thank you!

@imjuni imjuni closed this as completed Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants