Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web: black bezels in video viewer #10526

Open
1 of 3 tasks
pyorot opened this issue Jun 21, 2024 · 0 comments · May be fixed by #10667
Open
1 of 3 tasks

Web: black bezels in video viewer #10526

pyorot opened this issue Jun 21, 2024 · 0 comments · May be fixed by #10667

Comments

@pyorot
Copy link
Contributor

pyorot commented Jun 21, 2024

The bug

A change was made in #8757 to close #6191, with a Google-derived like/comment UI control overlapping HTML video player volume/settings/fullscreen controls. Unfortunately, the change simply added a bottom bezel and so shrank the video player, which has made the UI inconsistent with photos, most notably when clicking to play a Live Photo (which then shrinks).

style="height: calc(100% - 64px)" [see original]

image

The discussion mentions several better ways of handling the problem, most notably shifting the Google controls up on videos, which would be inconsistent with their position on photos, but not annoyingly so. The bezeling change is justified by "This would have different effects on different screen sizes, but most of the time it would be an improvement.", which I think is a dubious claim. The Google controls don't even show up on my client and I don't want or know how to make them do so.

Google Photos itself doesn't even bother lol (which is still preferable to the bezels imo).

image

The OS that Immich Server is running on

Debian 12

Version of Immich Server

v1.106.3

Version of Immich Mobile App

n/a

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

-

Your .env content

-

Reproduction steps

Always happens on web video player.

Relevant log output

No response

Additional information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant